pf: make pf_setup_pdesc() a static function
ClosedPublic
Actions

Authored by kp on Sep 19 2024, 8:24 PM.

Tags

None

Referenced Files

	F137174171: D46706.id143495.diff
	Fri, Nov 21, 9:07 AM

	Unknown Object (File)
	Mon, Nov 17, 3:17 PM

	Unknown Object (File)
	Fri, Nov 7, 1:12 AM

	Unknown Object (File)
	Sun, Oct 26, 8:41 AM

	Unknown Object (File)
	Sun, Oct 26, 6:48 AM

	Unknown Object (File)
	Oct 22 2025, 2:51 AM

	Unknown Object (File)
	Oct 18 2025, 10:12 AM

	Unknown Object (File)
	Oct 18 2025, 8:08 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG86fc6f838ed2: pf: make pf_setup_pdesc() a static function

Summary

We only ever call it from pf_test(), and implement it in the same source file.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59536
Build 56423: arc lint + arc unit

Event Timeline

kp created this revision.Sep 19 2024, 8:24 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptSep 19 2024, 8:24 PM

kp requested review of this revision.Sep 19 2024, 8:24 PM

Harbormaster completed remote builds in B59536: Diff 143495.Sep 19 2024, 8:24 PM

kp added a parent revision: D46705: pf: fold pf_test_fragment() into pf_test_rule().Sep 19 2024, 8:24 PM

kp added a child revision: D46707: pf: move normalisation into pf_setup_pdesc().

This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2024, 10:17 PM

Closed by commit rG86fc6f838ed2: pf: make pf_setup_pdesc() a static function (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG86fc6f838ed2: pf: make pf_setup_pdesc() a static function.

Revision Contents
Changeset List

Path

Size

sys/

net/

pfvar.h

7 lines

netpfil/

pf/

pf.c

2 lines

Diff 143495

View Options

sys/net/pfvar.h