Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2902 Build 2928: arc lint + arc unit
Event Timeline
Is there something needed in ObsoleteFiles?
| usr.sbin/uathload/Makefile | ||
|---|---|---|
| 8 | ${SHAREDIR}/firmware | |
Fixes, per bdrewery
Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it
in.
Fix hier.7
Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it
in.
| share/man/man7/hier.7 | ||
|---|---|---|
| 549–550 | There seems to be a word missing before done. | |
I don't think so, unless we're using it for optional file pruning.
Ahh, it should go in the .if ${MK_USB} == no section in tools/build/mk/OptionalObsoleteFiles.inc.
We can also lose the .if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 50200) condition in usr.sbin/Makefile
| share/man/man7/hier.7 | ||
|---|---|---|
| 31 | .Dd needs a bump | |
Thanks!
We can also lose the .if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 50200) condition in usr.sbin/Makefile
We can? This looks like it is due to the rest of the program, not this aspect of it. Am I missing something?
Obsolete files and hier.7 fix.
Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it
in.
Doh! bump hier.7 .Dd
Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it
in.
I think @br made a mistake in basing this on the compiler instead of linker version; the commit that brought that test in was:
Remove uathload from build due to issue with GCC 5.2.0: "ld: --relax and -r may not be used together." Requires fixing ld command line arguments and testing.
Anyway, perhaps just commit this change and br@ can revert the GCC test.
| share/man/man7/hier.7 | ||
|---|---|---|
| 549–550 | This seems a bit awkward to me, what about just "Firmware files for use by various user land firmware loaders / programmers"? | |
What the heck, always build uathload.
Wordsmithing.
Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it
in.
| share/man/man7/hier.7 | ||
|---|---|---|
| 549–550 | Maybe this is even better? | |
| share/man/man7/hier.7 | ||
|---|---|---|
| 549–550 | sounds good to me | |
| share/man/man7/hier.7 | ||
|---|---|---|
| 549 | Should be "userland", no space. A grep of /usr/src in 10-stable suggests 986 occurrences to only 23 of the two-word variety. | |
| share/man/man7/hier.7 | ||
|---|---|---|
| 549 | ||