Page MenuHomeFreeBSD
Differential D5639

Just install ar5523.bin into /usr/share/firmware and stop compiling it in.
ClosedPublic
Actions

Authored by imp on Mar 14 2016, 11:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 3:30 AM
Unknown Object (File)
Nov 17 2024, 4:54 PM
Unknown Object (File)
Nov 5 2024, 1:36 PM
Unknown Object (File)
Nov 4 2024, 11:23 PM
Unknown Object (File)
Nov 4 2024, 3:00 PM
Unknown Object (File)
Nov 4 2024, 3:00 PM
Unknown Object (File)
Nov 4 2024, 3:00 PM
Unknown Object (File)
Nov 4 2024, 3:00 PM
View All Files
Subscribers
br
wblock

Details

Reviewers
emaste
adrian
bdrewery
Group Reviewers
manpages

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2904
Build 2930: arc lint + arc unit

Event Timeline

imp updated this revision to Diff 14323.Mar 14 2016, 11:14 PM
imp retitled this revision from to Just install ar5523.bin into /usr/share/firmware and stop compiling it in..
imp updated this object.
imp edited the test plan for this revision. (Show Details)
imp added reviewers: bdrewery, emaste, adrian.Mar 14 2016, 11:16 PM
adrian accepted this revision.Mar 14 2016, 11:17 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2016, 11:17 PM
emaste accepted this revision.Mar 14 2016, 11:20 PM
emaste edited edge metadata.

Thanks!

bdrewery requested changes to this revision.Mar 14 2016, 11:26 PM
bdrewery edited edge metadata.

Is there something needed in ObsoleteFiles?

usr.sbin/uathload/Makefile
8

${SHAREDIR}/firmware

This revision now requires changes to proceed.Mar 14 2016, 11:26 PM
imp updated this revision to Diff 14325.Mar 14 2016, 11:32 PM
imp edited edge metadata.

Fixes, per bdrewery

Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it

in.

emaste accepted this revision.Mar 14 2016, 11:33 PM
emaste edited edge metadata.
imp added a comment.Mar 14 2016, 11:33 PM
In D5639#120316, @bdrewery wrote:

Is there something needed in ObsoleteFiles?

I don't think so, unless we're using it for optional file pruning.

bdrewery added a comment.Mar 14 2016, 11:34 PM

heir.7 needs updating too

imp updated this revision to Diff 14327.Mar 14 2016, 11:36 PM
imp edited edge metadata.

Fix hier.7

Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it

in.

Herald added a reviewer: manpages. · View Herald TranscriptMar 14 2016, 11:36 PM
bdrewery added inline comments.Mar 14 2016, 11:37 PM
share/man/man7/hier.7
549–550

There seems to be a word missing before done.

emaste added a comment.Mar 14 2016, 11:38 PM

I don't think so, unless we're using it for optional file pruning.

Ahh, it should go in the .if ${MK_USB} == no section in tools/build/mk/OptionalObsoleteFiles.inc.

We can also lose the .if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 50200) condition in usr.sbin/Makefile

emaste added inline comments.Mar 14 2016, 11:39 PM
share/man/man7/hier.7
31

.Dd needs a bump

imp added a comment.Mar 14 2016, 11:40 PM
In D5639#120349, @emaste wrote:

Ahh, it should go in the .if ${MK_USB} == no section in tools/build/mk/OptionalObsoleteFiles.inc.

Thanks!

We can also lose the .if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 50200) condition in usr.sbin/Makefile

We can? This looks like it is due to the rest of the program, not this aspect of it. Am I missing something?

imp updated this revision to Diff 14329.Mar 14 2016, 11:42 PM
imp edited edge metadata.

Obsolete files and hier.7 fix.

Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it

in.

Herald edited edge metadata. · View Herald TranscriptMar 14 2016, 11:42 PM
imp updated this revision to Diff 14330.Mar 14 2016, 11:43 PM
imp edited edge metadata.

Doh! bump hier.7 .Dd

Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it

in.

Herald edited edge metadata. · View Herald TranscriptMar 14 2016, 11:43 PM
emaste added a subscriber: br.Mar 14 2016, 11:46 PM
In D5639#120359, @imp wrote:
In D5639#120349, @emaste wrote:

We can also lose the .if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 50200) condition in usr.sbin/Makefile

We can? This looks like it is due to the rest of the program, not this aspect of it. Am I missing something?

I think @br made a mistake in basing this on the compiler instead of linker version; the commit that brought that test in was:

Remove uathload from build due to issue with GCC 5.2.0:
"ld: --relax and -r may not be used together."
Requires fixing ld command line arguments and testing.

Anyway, perhaps just commit this change and br@ can revert the GCC test.

emaste accepted this revision.Mar 14 2016, 11:48 PM
emaste edited edge metadata.
emaste added inline comments.
share/man/man7/hier.7
549–550

This seems a bit awkward to me, what about just "Firmware files for use by various user land firmware loaders / programmers"?

bdrewery accepted this revision.Mar 14 2016, 11:52 PM
bdrewery edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2016, 11:52 PM
imp updated this revision to Diff 14331.Mar 15 2016, 12:49 AM
imp edited edge metadata.

What the heck, always build uathload.
Wordsmithing.

Updating D5639: Just install ar5523.bin into /usr/share/firmware and stop compiling it

in.

This revision now requires review to proceed.Mar 15 2016, 12:49 AM
Herald edited edge metadata. · View Herald TranscriptMar 15 2016, 12:49 AM
emaste accepted this revision.Mar 15 2016, 1:05 AM
emaste edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2016, 1:05 AM
imp added inline comments.Mar 15 2016, 1:36 AM
share/man/man7/hier.7
549–550

Maybe this is even better?

emaste added inline comments.Mar 15 2016, 1:38 AM
share/man/man7/hier.7
549–550

sounds good to me

wblock added a subscriber: wblock.Mar 15 2016, 10:41 PM
wblock added inline comments.
share/man/man7/hier.7
549

Should be "userland", no space. A grep of /usr/src in 10-stable suggests 986 occurrences to only 23 of the two-word variety.

emaste closed this revision.Mar 28 2016, 3:32 PM

Was committed as rS296889

emaste added inline comments.Mar 28 2016, 3:37 PM
share/man/man7/hier.7
549

I think @imp's commit was prior to your comment; this instance should just be included in a broad sweep of these I'd think.

wblock added inline comments.Mar 28 2016, 5:57 PM
share/man/man7/hier.7
549

Done in https://svnweb.freebsd.org/base?view=revision&revision=297357

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
share/
man/
man7/
4 lines
tools/
build/
mk/
1 line
usr.sbin/
2 lines
uathload/
22 lines
28 lines

Diff 14331

View Options

etc/mtree/BSD.usr.dist

Loading...
View Options

share/man/man7/hier.7

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...
View Options

usr.sbin/Makefile

Loading...
View Options

usr.sbin/uathload/Makefile

Loading...
View Options

usr.sbin/uathload/uathload.c

Loading...