Page MenuHomeFreeBSD
Differential D45930

linker: Add MODINFOMD_SPLASH type
ClosedPublic
Actions

Authored by manu on Jul 9 2024, 12:44 PM.
Tags
None
Referenced Files
F102844394: D45930.id140717.diff
Sun, Nov 17, 10:02 PM
F102829873: D45930.id.diff
Sun, Nov 17, 5:40 PM
F102829871: D45930.id140788.diff
Sun, Nov 17, 5:40 PM
F102828669: D45930.id140725.diff
Sun, Nov 17, 5:19 PM
F102826922: D45930.diff
Sun, Nov 17, 5:05 PM
Unknown Object (File)
Oct 9 2024, 12:52 AM
Unknown Object (File)
Oct 7 2024, 2:51 AM
Unknown Object (File)
Sep 30 2024, 8:39 PM
View All 37 Files
Subscribers
imp
olce

Details

Reviewers
tsoome
Group Reviewers
Loader
Commits
rG014edaa360ce: linker: Add MODINFOMD_SPLASH type
rG966e53a4e563: linker: Add MODINFOMD_SPLASH type
Summary

This mod type and structure holds the splash screen data and metadata.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Jul 9 2024, 12:44 PM
Herald added subscribers: olce, imp. · View Herald TranscriptJul 9 2024, 12:44 PM
manu requested review of this revision.Jul 9 2024, 12:44 PM
Harbormaster completed remote builds in B58580: Diff 140717.Jul 9 2024, 12:44 PM
manu added a child revision: D45931: vt: splash: Use splash screen passed from loader.Jul 9 2024, 12:44 PM
manu added a reviewer: Loader.Jul 9 2024, 12:45 PM
manu added a parent revision: D45929: vt: Add vd_bitblt_argb.
tsoome accepted this revision.Jul 9 2024, 12:58 PM
This revision is now accepted and ready to land.Jul 9 2024, 12:58 PM
imp added inline comments.Jul 9 2024, 2:14 PM
sys/sys/splash.h
4

Maybe use spdx instead of boilerplate?

manu added inline comments.Jul 9 2024, 2:37 PM
sys/sys/splash.h
4

You mean just spdx and copyright or add spdx ?

imp added inline comments.Jul 9 2024, 2:41 PM
sys/sys/splash.h
4

Sorry. Doing this on my phone...

I mean just use the spdx expression and not use the boilerplate. It takes up more than half of this file....

manu updated this revision to Diff 140725.Jul 9 2024, 2:46 PM

Add spdx tag and remove full boilerplate licence.

This revision now requires review to proceed.Jul 9 2024, 2:46 PM
Harbormaster completed remote builds in B58586: Diff 140725.Jul 9 2024, 2:46 PM
manu marked 2 inline comments as done.Jul 9 2024, 2:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2024, 6:51 AM
Closed by commit rG966e53a4e563: linker: Add MODINFOMD_SPLASH type (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG966e53a4e563: linker: Add MODINFOMD_SPLASH type.
manu added a commit: rG014edaa360ce: linker: Add MODINFOMD_SPLASH type.Jul 29 2024, 4:38 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
9 lines
sys/
1 line
17 lines

Diff 140788

View Options

sys/kern/subr_module.c

Loading...
View Options

sys/sys/linker.h

Loading...
View Options

sys/sys/splash.h

Loading...