Page MenuHomeFreeBSD
Differential D45879

stand: Remove obsolete junk
ClosedPublic
Actions

Authored by imp on Jul 5 2024, 6:23 PM.
Tags
None
Referenced Files
F174624149: D45879.diff
Sun, Oct 4, 6:30 PM
Unknown Object (File)
Fri, Oct 2, 8:10 PM
Unknown Object (File)
Mon, Sep 28, 8:57 PM
Unknown Object (File)
Fri, Sep 18, 7:19 PM
Unknown Object (File)
Wed, Sep 16, 11:15 AM
Unknown Object (File)
Mon, Sep 14, 7:55 PM
Unknown Object (File)
Mon, Sep 14, 10:51 AM
Unknown Object (File)
Mon, Sep 14, 10:15 AM
View All Files
Subscribers
bcran
dab
jhb
rgrimes

Details

Reviewers
kevans
manu
jhb
Group Reviewers
bhyve
Commits
rG4d66d691e35b: stand: Remove obsolete junk
rG384215cb9a3d: stand: Remove obsolete junk
rG8165650389ba: stand: Remove obsolete junk
Summary

We long ago changed newvers.sh to make these comments bogus. Remove
them since every single one of them is broken after the $FreeBSD$
removal.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58513
Build 55401: arc lint + arc unit

Event Timeline

imp created this revision.Jul 5 2024, 6:23 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 5 2024, 6:23 PM
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript
imp requested review of this revision.Jul 5 2024, 6:23 PM
Harbormaster completed remote builds in B58513: Diff 140582.Jul 5 2024, 6:23 PM
imp added a child revision: D45880: stand: Kill commented out line.Jul 5 2024, 6:23 PM
jhb added a subscriber: jhb.Jul 9 2024, 1:55 PM

Does anything parse this file still, and if so, how does it parse it?

jhb accepted this revision.Jul 9 2024, 1:55 PM
This revision is now accepted and ready to land.Jul 9 2024, 1:55 PM
imp added a comment.Jul 9 2024, 1:57 PM
In D45879#1047007, @jhb wrote:

Does anything parse this file still, and if so, how does it parse it?

Since 1998, i think, we've just looked at the first line starting with a number. And that's only to bake the version into vers.sh.

kevans accepted this revision.Jul 9 2024, 8:39 PM
Closed by commit rG8165650389ba: stand: Remove obsolete junk (authored by imp). · Explain WhyJul 29 2024, 10:57 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG8165650389ba: stand: Remove obsolete junk.
imp added a commit: rG384215cb9a3d: stand: Remove obsolete junk.Aug 1 2024, 2:51 PM
imp added a commit: rG4d66d691e35b: stand: Remove obsolete junk.Aug 1 2024, 2:57 PM

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
4 lines
3 lines
i386/
loader/
4 lines
kboot/
kboot/
5 lines
powerpc/
ofw/
4 lines
uboot/
4 lines
userboot/
userboot/
1 line

Diff 140582

View Options

stand/efi/loader/version

Loading...
View Options

stand/efi/loader/version.veriexec

Loading...
View Options

stand/i386/loader/version

Loading...
View Options

stand/kboot/kboot/version

Loading...
View Options

stand/powerpc/ofw/version

Loading...
View Options

stand/uboot/version

Loading...
View Options

stand/userboot/userboot/version

Loading...