Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rGf841cb63687b: bhyve: trap protected BAR regions of passthru devices

Summary

At the moment, the list of protected BAR regions is unused by the passthru
emulation. Make use of it when mapping the BAR regions. This causes bhyve to
trap those regions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58050
Build 54938: arc lint + arc unit

Event Timeline

corvink created this revision.May 24 2024, 11:34 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 24 2024, 11:34 AM

corvink requested review of this revision.May 24 2024, 11:34 AM

Harbormaster completed remote builds in B57896: Diff 139037.May 24 2024, 11:34 AM

corvink added a child revision: D45341: bhyve: add interface to protect BAR regions of passthru devices.May 24 2024, 11:35 AM

corvink added a parent revision: D45339: bhyve: add BAR handler list for passthru devices.

markj added inline comments.May 27 2024, 3:59 PM

usr.sbin/bhyve/pci_passthru.c
1270–1271	Have you tried using tools/build/checkstyle9.pl?
1300

fix style issues

Harbormaster completed remote builds in B58050: Diff 139424.Jun 4 2024, 8:34 AM

corvink marked 2 inline comments as done.Jun 4 2024, 8:36 AM

corvink added inline comments.

usr.sbin/bhyve/pci_passthru.c
1270–1271	Wasn't aware of this helper tool. I'm always using the top level .clang-format. Unfortunately, it seems to be incorrect for some cases.

ping

rebase onto main

Harbormaster completed remote builds in B64801: Diff 156884.Jun 12 2025, 1:46 PM

Seems ok to me overall.

usr.sbin/bhyve/pci_passthru.c
1271
1301	You could perhaps use `trunc_page` and `round_page` here if you wished: handler_off = trunc_page(handler->off); handler_end = round_page(handler->off + handler->len);
1306