Page MenuHomeFreeBSD
Differential D45342

bhyve: protect MMIO mapped BDSM register
ClosedPublic
Actions

Authored by corvink on May 24 2024, 11:35 AM.
Tags
None
Referenced Files
F159761480: D45342.id156886.diff
Wed, Jun 17, 11:02 PM
F159753028: D45342.id139039.diff
Wed, Jun 17, 9:27 PM
Unknown Object (File)
Wed, Jun 17, 12:44 AM
Unknown Object (File)
Tue, Jun 16, 12:37 PM
Unknown Object (File)
Mon, Jun 15, 8:20 AM
Unknown Object (File)
Sat, Jun 13, 11:52 PM
Unknown Object (File)
Thu, Jun 11, 1:39 AM
Unknown Object (File)
Wed, Jun 10, 11:42 PM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rG6374c45fbaf7: bhyve: protect MMIO mapped BDSM register
Summary

The Windows graphics driver reads the value of the BDSM register from MMIO
space. This value makes no sense in our virtual environment because it's a host
address. Therefore, we have to trap and emulate it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57898
Build 54786: arc lint + arc unit

Event Timeline

corvink created this revision.May 24 2024, 11:35 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 24 2024, 11:35 AM
corvink requested review of this revision.May 24 2024, 11:35 AM
Harbormaster completed remote builds in B57898: Diff 139039.May 24 2024, 11:35 AM
corvink added a parent revision: D45341: bhyve: add interface to protect BAR regions of passthru devices.May 24 2024, 11:35 AM
corvink updated this revision to Diff 156886.Jun 12 2025, 1:46 PM
  • rebase onto main
Harbormaster completed remote builds in B64803: Diff 156886.Jun 12 2025, 1:46 PM
markj added inline comments.Jun 17 2025, 12:38 PM
usr.sbin/bhyve/amd64/pci_gvt-d.c
64

The indentation of the case labels should be the same as the indentation of switch. .clang-format has IndentCaseLabels: false for this.

88

Is it correct that the offset is the same for both writes?

corvink updated this revision to Diff 157504.Jun 24 2025, 6:27 AM
  • fix style issue
  • use correct offset for 64 bit BDSM read/writes
Harbormaster completed remote builds in B65041: Diff 157504.Jun 24 2025, 6:27 AM
corvink marked 2 inline comments as done.Jun 24 2025, 6:27 AM
corvink updated this revision to Diff 157703.Jun 27 2025, 7:41 AM
  • use uint64_t instead of vm_* types
  • account for new handler interface (including baridx)
Harbormaster completed remote builds in B65117: Diff 157703.Jun 27 2025, 7:41 AM
jhb accepted this revision.Jun 30 2025, 6:32 PM
jhb added inline comments.
usr.sbin/bhyve/amd64/pci_gvt-d.c
47

Maybe add a #define for this magic number to document it a bit more?

This revision is now accepted and ready to land.Jun 30 2025, 6:32 PM
Closed by commit rG6374c45fbaf7: bhyve: protect MMIO mapped BDSM register (authored by corvink). · Explain WhyAug 5 2025, 2:04 PM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG6374c45fbaf7: bhyve: protect MMIO mapped BDSM register.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
amd64/
57 lines

Diff 139039

View Options

usr.sbin/bhyve/amd64/pci_gvt-d.c

Loading...