Differential D45326

riscv: Don't handle missing kernel L3 pages
ClosedPublic
Actions

Authored by mhorne on May 23 2024, 7:53 PM.

Tags

None

Referenced Files

	F87075263: D45326.id139859.diff
	Sat, Jun 29, 12:26 AM

	F87073753: D45326.id139009.diff
	Sat, Jun 29, 12:04 AM

	Unknown Object (File)
	Wed, Jun 26, 5:03 AM

	Unknown Object (File)
	Mon, Jun 17, 2:02 AM

	Unknown Object (File)
	Fri, Jun 14, 6:43 PM

	Unknown Object (File)
	Sun, Jun 9, 4:45 AM

	Unknown Object (File)
	Thu, May 30, 5:17 PM

	Unknown Object (File)
	Thu, May 30, 10:46 AM

View All 11 Files

Subscribers

Details

Reviewers

markj
br
jrtc27
jhb

Group Reviewers

Commits

rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages

Summary

This code path should never be hit, if it does it means we did not
bootstrap correctly. Turn it into a panic like we do on amd64 and arm64.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 57880
Build 54768: arc lint + arc unit

Event Timeline

mhorne created this revision.May 23 2024, 7:53 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2024, 7:53 PM

mhorne requested review of this revision.May 23 2024, 7:53 PM

Harbormaster completed remote builds in B57880: Diff 139009.May 23 2024, 7:53 PM

mhorne added a parent revision: D45325: riscv: adjust physmem reservation.May 23 2024, 7:53 PM

mhorne added a child revision: D45327: riscv: rework page table bootstrap.

I have a vague memory that this was needed at some point, but after digging for a while I can't find it. It'll be pretty obvious if the premise of the commit is wrong, so this seems ok.

This revision is now accepted and ready to land.May 27 2024, 2:07 PM

jhb accepted this revision.Thu, Jun 6, 5:24 PM

Closed by commit rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages (authored by mhorne). · Explain WhyFri, Jun 14, 6:02 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages.

Revision Contents
Changeset List

Path

Size

sys/

riscv/

riscv/

43 lines

Diff 139009

sys/riscv/riscv/pmap.c

Loading...