Page MenuHomeFreeBSD
Differential D45249

buf: define and use BUF_DISOWNED
ClosedPublic
Actions

Authored by rlibby on May 19 2024, 1:59 AM.
Tags
None
Referenced Files
F114622747: D45249.id138855.diff
Mon, Apr 14, 1:12 PM
Unknown Object (File)
Mon, Apr 14, 9:50 AM
Unknown Object (File)
Mon, Apr 14, 9:32 AM
Unknown Object (File)
Mar 2 2025, 6:26 AM
Unknown Object (File)
Feb 27 2025, 5:48 AM
Unknown Object (File)
Feb 26 2025, 5:07 PM
Unknown Object (File)
Feb 26 2025, 2:51 AM
Unknown Object (File)
Feb 8 2025, 8:06 PM
View All 68 Files
Subscribers
imp

Details

Reviewers
markj
mjg
mckusick
imp
kib
Commits
rGbd56aad33c25: buf: define and use BUF_DISOWNED
Summary

Implement an API where previously code was directly reaching into the
buf's internal lock.

Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57761
Build 54649: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
geom/
4 lines
sys/
7 lines

Diff 138730

View Options

sys/geom/geom_vfs.c

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines if (bootverbose) {
unit->unit, busno, slot, func); unit->unit, busno, slot, func);
} }
return (false); return (false);
} }
iommu_set_buswide_ctx(unit, busno); iommu_set_buswide_ctx(unit, busno);
return (true); return (true);
} }
void
iommu_set_buswide_ctx(struct iommu_unit *unit, u_int busno)
kibUnsubmitted
Not Done
Inline Actions

I still prefer to have this code fragment to exist as a function.

kib: I still prefer to have this code fragment to exist as a function.
{
MPASS(busno <= PCI_BUSMAX);
IOMMU_LOCK(unit);
unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] |=
1 << (busno % (NBBY * sizeof(uint32_t)));
IOMMU_UNLOCK(unit);
}
bool
iommu_is_buswide_ctx(struct iommu_unit *unit, u_int busno)
{
MPASS(busno <= PCI_BUSMAX);
return ((unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] &
(1U << (busno % (NBBY * sizeof(uint32_t))))) != 0);
}
static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map"); static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map");
static void iommu_bus_schedule_dmamap(struct iommu_unit *unit, static void iommu_bus_schedule_dmamap(struct iommu_unit *unit,
struct bus_dmamap_iommu *map); struct bus_dmamap_iommu *map);
static int static int
iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment,
bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr, bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr,
▲ Show 20 Lines • Show All 714 Lines • Show Last 20 Lines
View Options

sys/sys/buf.h

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines if (bootverbose) {
unit->unit, busno, slot, func); unit->unit, busno, slot, func);
} }
return (false); return (false);
} }
iommu_set_buswide_ctx(unit, busno); iommu_set_buswide_ctx(unit, busno);
return (true); return (true);
} }
void
iommu_set_buswide_ctx(struct iommu_unit *unit, u_int busno)
kibUnsubmitted
Not Done
Inline Actions

I still prefer to have this code fragment to exist as a function.

kib: I still prefer to have this code fragment to exist as a function.
{
MPASS(busno <= PCI_BUSMAX);
IOMMU_LOCK(unit);
unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] |=
1 << (busno % (NBBY * sizeof(uint32_t)));
IOMMU_UNLOCK(unit);
}
bool
iommu_is_buswide_ctx(struct iommu_unit *unit, u_int busno)
{
MPASS(busno <= PCI_BUSMAX);
return ((unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] &
(1U << (busno % (NBBY * sizeof(uint32_t))))) != 0);
}
static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map"); static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map");
static void iommu_bus_schedule_dmamap(struct iommu_unit *unit, static void iommu_bus_schedule_dmamap(struct iommu_unit *unit,
struct bus_dmamap_iommu *map); struct bus_dmamap_iommu *map);
static int static int
iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment,
bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr, bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr,
▲ Show 20 Lines • Show All 714 Lines • Show Last 20 Lines