aarch64: disable LIB32 with gcc
ClosedPublic
Actions

Authored by brooks on May 3 2024, 10:23 PM.

Details

Reviewers

• karels
jrtc27
emaste

Commits

rG16d8dfde0c0f: aarch64: disable LIB32 with gcc

Summary

gcc doesn't have -m32 support on aarch64 so mark LIB32 broken there.

We have to check both COMPILER_TYPE and X_COMPILER_TYPE becuase
X_COMPILER_TYPE is only conditionally set and COMPILER_TYPE is the host
compiler in Makefile.inc1.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 57619
Build 54507: arc lint + arc unit

Event Timeline

brooks created this revision.May 3 2024, 10:23 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptMay 3 2024, 10:23 PM

brooks requested review of this revision.May 3 2024, 10:23 PM

Harbormaster completed remote builds in B57581: Diff 138130.May 3 2024, 10:24 PM

The easiest way to address this would probably be a cross toolchain wrapper script that picks the right compiler when -m32 is on the command line, but just disabling it for now seems reasonable. (I'm trying to test make tinderbox with gcc13 and this was one of the issues I encountered.)

jrtc27 added inline comments.May 3 2024, 10:33 PM

share/mk/src.opts.mk
306	Won't this do weird things at the top level if CC is gcc but XCC is clang?

brooks added inline comments.May 4 2024, 12:21 AM

share/mk/src.opts.mk
306	I guess we might want `((defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} != "gcc") \|\| (!defined(X_COMPILER_TYPE) && ${COMPILER_TYPE} != "gcc"))` instead so we only consider COMPILER_TYPE when X_COMPILER_TYPE is not defined.