Differential D45095

sound: Remove unused "num" argument from chn_init() and related callers
ClosedPublic
Actions

Authored by christos on May 5 2024, 4:15 PM.

Tags

None

Referenced Files

	F175293342: D45095.id138150.diff
	Fri, Oct 9, 5:51 PM

	F175293331: D45095.id.diff
	Fri, Oct 9, 5:51 PM

	F175293303: D45095.id138181.diff
	Fri, Oct 9, 5:50 PM

	F175293259: D45095.diff
	Fri, Oct 9, 5:50 PM

	Unknown Object (File)
	Mon, Oct 5, 12:41 AM

	Unknown Object (File)
	Mon, Oct 5, 12:02 AM

	Unknown Object (File)
	Sun, Oct 4, 11:05 PM

	Unknown Object (File)
	Sat, Sep 12, 12:07 AM

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG17a50abe0e19: sound: Remove unused "num" argument from chn_init() and related callers
rG3af2beb8b24b: sound: Remove unused "num" argument from chn_init() and related callers

Summary

It is always -1 (i.e unused).

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.May 5 2024, 4:15 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 5 2024, 4:15 PM

christos requested review of this revision.May 5 2024, 4:15 PM

Harbormaster completed remote builds in B57588: Diff 138150.May 5 2024, 4:15 PM

christos mentioned this in D44993: sound: Merge pcm_chn_create() and chn_init().May 5 2024, 4:15 PM

christos added parent revisions: D45015: sound: Move vchan-related code to pcm/vchan.*, D44993: sound: Merge pcm_chn_create() and chn_init().

Looks good to me, but I cannot compile and test it. Patch doesn't apply here locally because I'm missing previous commits. Time to get that stuff merged ;-)

This revision is now accepted and ready to land.May 6 2024, 4:42 PM

Closed by commit rG3af2beb8b24b: sound: Remove unused "num" argument from chn_init() and related callers (authored by christos). · Explain WhyMay 6 2024, 6:39 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG3af2beb8b24b: sound: Remove unused "num" argument from chn_init() and related callers.

christos added a commit: rG17a50abe0e19: sound: Remove unused "num" argument from chn_init() and related callers.May 17 2024, 7:34 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

2 lines

11 lines

4 lines

4 lines

27 lines

Diff 138181

sys/dev/sound/pcm/channel.h

Loading...

sys/dev/sound/pcm/channel.c

Loading...

sys/dev/sound/pcm/sound.c

Loading...

sys/dev/sound/pcm/vchan.h

Loading...

sys/dev/sound/pcm/vchan.c

Loading...