Page MenuHomeFreeBSD

sound: Move vchan-related code to pcm/vchan.*
ClosedPublic

Authored by christos on Apr 29 2024, 5:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 7:44 AM
Unknown Object (File)
Wed, Nov 5, 9:02 PM
Unknown Object (File)
Wed, Nov 5, 9:50 AM
Unknown Object (File)
Wed, Nov 5, 5:07 AM
Unknown Object (File)
Wed, Nov 5, 5:07 AM
Unknown Object (File)
Wed, Nov 5, 4:27 AM
Unknown Object (File)
Wed, Nov 5, 1:33 AM
Unknown Object (File)
Wed, Nov 5, 12:20 AM
Subscribers

Details

Summary

pcm/sound.* contains code that should be part of pcm/vchan.*.

Changes:

  • pcm_setvchans() -> vchan_setnew()
  • pcm_setmaxautovchans() -> vchan_setmaxauto()
  • hw.snd.maxautovchans moved to pcm/vchan.c
  • snd_maxautovchans declaration moved to pcm/vchan.h and definition to pcm/vchan.c

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 30 2024, 12:19 AM

What is this diff based on? I can't apply it on any branch I have.

What is this diff based on? I can't apply it on any branch I have.

I forgot to stack the patches, but it is diffed against the previous ones. I thought it wasn't needed, but I can diff against main and reupload if you want.

What is this diff based on? I can't apply it on any branch I have.

I forgot to stack the patches, but it is diffed against the previous ones. I thought it wasn't needed, but I can diff against main and reupload if you want.

I suppose it's fine, there's no functional changes and it compiles for you and Mark. I'm not a reviewer for all of your patches so I'll naturally miss some.