Details

Reviewers

imp

Commits

rGd86edc181ab2: nvmf.h: New header defining ioctls for NVMe over Fabrics

Summary

This defines structures, ioctl commands, and related constants used
for both the Fabrics host and controller.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57510
Build 54398: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 9 2024, 11:03 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 9 2024, 11:03 PM

jhb requested review of this revision.Apr 9 2024, 11:03 PM

Harbormaster completed remote builds in B56997: Diff 136802.Apr 9 2024, 11:03 PM

jhb added a parent revision: D44705: nvmf_proto.h: Add additional types and constants from the 1.1 spec.Apr 9 2024, 11:03 PM

jhb added a child revision: D44707: nvmf: Install nvmf.h and nvmf_proto.h in /usr/include/dev/nvmf.

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

sys/dev/nvme/nvme.h
47	won't line numbers go stale quickly?

This revision is now accepted and ready to land.Apr 13 2024, 5:53 PM

In D44706#1020670, @imp wrote:

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

Hmm, are we ready to do that? I know we have some SPDX-only files in the tree and are kind of allowing it, but I wasn't sure we'd crossed the point to preferring that by default.

sys/dev/nvme/nvme.h
47	Not the line number, the constant `200` as the second argument to `_IO*`

In D44706#1021491, @jhb wrote:

In D44706#1020670, @imp wrote:

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

Hmm, are we ready to do that? I know we have some SPDX-only files in the tree and are kind of allowing it, but I wasn't sure we'd crossed the point to preferring that by default.