sound: Add __assert_unreachable() to default cases in pcm_chn_add() and pcm_chn_remove()
ClosedPublic
Actions

Authored by christos on Apr 28 2024, 4:54 PM.

Details

Reviewers

markj
emaste

Commits

rGe6e7bf7087fb: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and…
rG76f95bae092b: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and…

Summary

We should normally never enter these cases.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57426
Build 54314: arc lint + arc unit

Event Timeline

christos created this revision.Apr 28 2024, 4:54 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 28 2024, 4:54 PM

christos requested review of this revision.Apr 28 2024, 4:54 PM

Harbormaster completed remote builds in B57426: Diff 137778.Apr 28 2024, 4:54 PM

markj accepted this revision.Apr 28 2024, 4:55 PM

This revision is now accepted and ready to land.Apr 28 2024, 4:55 PM

christos added a child revision: D44998: sound: Convert pcm_chn_add() to void.Apr 28 2024, 5:32 PM

emaste accepted this revision.Apr 28 2024, 7:16 PM

Closed by commit rG76f95bae092b: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and… (authored by christos). · Explain WhyMay 6 2024, 6:37 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG76f95bae092b: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and….

christos added a commit: rGe6e7bf7087fb: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and….May 17 2024, 7:33 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sound.c

4 lines

Diff 137778

View Options

sound: Add __assert_unreachable() to default cases in pcm_chn_add() and pcm_chn_remove()ClosedPublicActions