Differential D44994

sound: Add __assert_unreachable() to default cases in pcm_chn_add() and pcm_chn_remove()
ClosedPublic
Actions

Authored by christos on Sun, Apr 28, 4:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 11, 3:24 PM

	Unknown Object (File)
	Wed, May 8, 1:20 PM

	Unknown Object (File)
	Mon, May 6, 11:29 PM

	Unknown Object (File)
	Thu, May 2, 2:47 PM

	Unknown Object (File)
	Tue, Apr 30, 4:26 PM

	Unknown Object (File)
	Tue, Apr 30, 6:40 AM

	Unknown Object (File)
	Tue, Apr 30, 6:40 AM

	Unknown Object (File)
	Mon, Apr 29, 10:12 PM

View All 9 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rG76f95bae092b: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and…

Summary

We should normally never enter these cases.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Sun, Apr 28, 4:54 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Apr 28, 4:54 PM

christos requested review of this revision.Sun, Apr 28, 4:54 PM

Harbormaster completed remote builds in B57426: Diff 137778.Sun, Apr 28, 4:54 PM

markj accepted this revision.Sun, Apr 28, 4:55 PM

This revision is now accepted and ready to land.Sun, Apr 28, 4:55 PM

christos added a child revision: D44998: sound: Convert pcm_chn_add() to void.Sun, Apr 28, 5:32 PM

emaste accepted this revision.Sun, Apr 28, 7:16 PM

Closed by commit rG76f95bae092b: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and… (authored by christos). · Explain WhyMon, May 6, 6:37 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG76f95bae092b: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and….

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

4 lines

Diff 138173

sys/dev/sound/pcm/sound.c

Loading...