Paths

Table of Contentst

Differential D44625

userboot: support environment and symlinks in test application
ClosedPublic
Actions

Authored by stevek on Apr 3 2024, 9:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 7:08 AM

	Unknown Object (File)
	Nov 22 2024, 1:11 PM

	Unknown Object (File)
	Oct 5 2024, 6:33 AM

	Unknown Object (File)
	Oct 2 2024, 9:42 AM

	Unknown Object (File)
	Oct 1 2024, 8:25 AM

	Unknown Object (File)
	Oct 1 2024, 1:23 AM

	Unknown Object (File)
	Sep 30 2024, 10:24 PM

	Unknown Object (File)
	Sep 30 2024, 1:10 PM

View All 39 Files

Subscribers

Details

Reviewers

imp
tsoome
manu
jhb

Group Reviewers

Commits

rG46b606c8fd9a: userboot: support environment and symlinks in test application

Summary

Pass the environment on to the loader.
Also define USERBOOT=1 in the environment varables.

Add support for symlinks in the test application open callback.

stat the root directory when opening file
Without this, running "ls" command on the root directory encounters
issues getting the directory listing.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57327
Build 54215: arc lint + arc unit

Event Timeline

stevek created this revision.Apr 3 2024, 9:31 PM

Herald added a reviewer: manu. · View Herald TranscriptApr 3 2024, 9:31 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: dab, rgrimes. · View Herald Transcript

stevek requested review of this revision.Apr 3 2024, 9:31 PM

Harbormaster completed remote builds in B56902: Diff 136501.Apr 3 2024, 9:31 PM

jhb added a subscriber: jhb.Apr 12 2024, 6:47 PM

jhb added inline comments.

stand/userboot/test/test.c
112	Do you still want this case? I think in the new code open() will fail with `EFAULT` due to the NULL path pointer, but `ENOENT` does seem like it might be the better error code if there is no host base path.
525

stevek added inline comments.Apr 24 2024, 6:49 PM

stand/userboot/test/test.c
112	That case is in the test_open() function.

Added parenthesis based on comments.

Harbormaster completed remote builds in B57327: Diff 137611.Apr 24 2024, 6:52 PM

jhb accepted this revision.Apr 30 2024, 8:03 PM

This revision is now accepted and ready to land.Apr 30 2024, 8:03 PM

Closed by commit rG46b606c8fd9a: userboot: support environment and symlinks in test application (authored by stevek). · Explain WhyApr 30 2024, 8:40 PM

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rG46b606c8fd9a: userboot: support environment and symlinks in test application.

Revision Contents
Changeset List

Path

Size

stand/

userboot/

test/

196 lines

Diff 137611

stand/userboot/test/test.c

Loading...