Page MenuHomeFreeBSD
Differential D44879

libc/quad: further narrow list of i386 symbols
ClosedPublic
Actions

Authored by brooks on Apr 19 2024, 9:29 PM.
Tags
None
Referenced Files
F171223184: D44879.id137423.diff
Wed, Sep 9, 3:30 PM
Unknown Object (File)
Tue, Sep 8, 9:07 PM
Unknown Object (File)
Aug 9 2026, 11:46 PM
Unknown Object (File)
Aug 8 2026, 6:32 PM
Unknown Object (File)
Aug 7 2026, 5:01 AM
Unknown Object (File)
Aug 3 2026, 9:16 AM
Unknown Object (File)
Aug 3 2026, 5:52 AM
Unknown Object (File)
Aug 2 2026, 6:01 AM
View All Files
Subscribers
imp

Details

Reviewers
dim
Commits
rGf0bd655a615e: libc/quad: further narrow list of i386 symbols
Summary

It's unclear to me why lld didn't complain about these are they aren't
present and haven't been. Instead ld.bfd complained.

Fixes: 6e6cd03c911c libc/quad: narrow list of symbols exposed on i386

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57237
Build 54125: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 19 2024, 9:29 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 19 2024, 9:29 PM
brooks requested review of this revision.Apr 19 2024, 9:29 PM
Harbormaster completed remote builds in B57237: Diff 137420.Apr 19 2024, 9:29 PM
brooks added a child revision: D44216: Make WITHOUT_UNDEFINED_VERSION the default.Apr 19 2024, 9:31 PM
dim accepted this revision.Apr 19 2024, 9:37 PM

LGTM. Should we mark this for MFC?

This revision is now accepted and ready to land.Apr 19 2024, 9:37 PM
brooks added a comment.Apr 19 2024, 9:54 PM

We could MFC this one, but it's mostly harmless and depends on another commit. Maybe as part of a WITHOUT_UNDEFINED_VERSION MFC batch.

Closed by commit rGf0bd655a615e: libc/quad: further narrow list of i386 symbols (authored by brooks). · Explain WhyApr 19 2024, 9:56 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGf0bd655a615e: libc/quad: further narrow list of i386 symbols.

Revision Contents
Changeset List

PathSize
lib/
libc/
quad/
8 lines

Diff 137420

View Options

lib/libc/quad/Symbol.map

Loading...