arm64: Always set the debug control and value regs
ClosedPublic
Actions

Authored by andrew on Mar 14 2024, 3:19 PM.

Details

Reviewers

manu
jhb

Group Reviewers

arm64

Commits

rGc3d86d27c3aa: arm64: Always set the debug control and value regs
rG531534bef90d: arm64: Always set the debug control and value regs
rG2e2c983d5234: arm64: Always set the debug control and value regs

Summary

When listing watchpoints we read the raw registers. To ensure we print
an accurate list always set the watchpoint and breakpoint registers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56596
Build 53484: arc lint + arc unit

Event Timeline

andrew created this revision.Mar 14 2024, 3:19 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 14 2024, 3:19 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Mar 14 2024, 3:19 PM

andrew added a parent revision: D44350: arm64: Mask non-debug exceptions when single stepping.

Harbormaster completed remote builds in B56596: Diff 135743.Mar 14 2024, 3:19 PM

andrew added a child revision: D44352: arm64: Use a switch to decide when to enable debug.Mar 14 2024, 3:19 PM

jhb accepted this revision.Mar 19 2024, 5:18 PM

This revision is now accepted and ready to land.Mar 19 2024, 5:18 PM

Closed by commit rG2e2c983d5234: arm64: Always set the debug control and value regs (authored by andrew). · Explain WhyMar 21 2024, 10:14 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG2e2c983d5234: arm64: Always set the debug control and value regs.

andrew added a commit: rG531534bef90d: arm64: Always set the debug control and value regs.Jul 15 2024, 12:38 PM

andrew added a commit: rGc3d86d27c3aa: arm64: Always set the debug control and value regs.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

debug_monitor.c

27 lines

Diff 135743

View Options

sys/arm64/arm64/debug_monitor.c

arm64: Always set the debug control and value regsClosedPublicActions