if_tuntap: simplify storage of per-vnet cloners
ClosedPublic
Actions

Authored by glebius on Mar 11 2024, 6:26 PM.

Details

Reviewers

melifaro
kevans
kp
zlei

Commits

rGfa93ba4097f0: if_tuntap: simplify storage of per-vnet cloners

Summary

There is no need to a separate structure neither for a linked list.
Provide each VNET with an array of pointers to if_clone that has the same
size as the driver list.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56543
Build 53431: arc lint + arc unit

Event Timeline

glebius created this revision.Mar 11 2024, 6:26 PM

Herald added subscribers: ae, imp. · View Herald TranscriptMar 11 2024, 6:26 PM

glebius requested review of this revision.Mar 11 2024, 6:26 PM

Harbormaster completed remote builds in B56543: Diff 135614.Mar 11 2024, 6:26 PM

glebius mentioned this in D44200: tun(4)/tap(4): allow devices to be configured as transient.Mar 11 2024, 6:31 PM

Nice, thanks. I think at one point I thought I might have something else worth adding to struct tuntap_driver_cloner, but if it hasn't happened in the intervening 5 years then I think it's safe to say that it's not going to happen.

This revision is now accepted and ready to land.Mar 12 2024, 5:31 AM

kp accepted this revision.Mar 12 2024, 10:04 PM