Differential D44211

nvme: Log reset success or failure to devd
ClosedPublic
Actions

Authored by imp on Mar 4 2024, 11:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 17, 6:49 PM

	Unknown Object (File)
	Fri, Sep 11, 8:18 AM

	Unknown Object (File)
	Thu, Sep 10, 2:34 PM

	Unknown Object (File)
	Sun, Sep 6, 1:13 PM

	Unknown Object (File)
	Sun, Sep 6, 4:41 AM

	Unknown Object (File)
	Sun, Sep 6, 1:40 AM

	Unknown Object (File)
	Sat, Sep 5, 3:16 PM

	Unknown Object (File)
	Sat, Sep 5, 12:43 PM

Subscribers

Details

Reviewers

chuck
jhb
mav

Commits

rG5cdedf676d03: nvme: Log reset success or failure to devd

Summary

We're logging when we start a reset, but not when we complete it, nor
the result. Create now log a success or timed_out event for the reset.
Currently, the only detectable error we have from reset is 'failure to
become ready in time,' though the code looks like it might be more
generic. Log this and if we ever have other failure modes, change the
logging to devd when that happens.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56432
Build 53320: arc lint + arc unit

Event Timeline

imp created this revision.Mar 4 2024, 11:48 PM

Herald added a subscriber: dab. · View Herald TranscriptMar 4 2024, 11:48 PM

imp requested review of this revision.Mar 4 2024, 11:48 PM

imp added a parent revision: D44210: nvme: Change devctl events for the controller.

imp added a child revision: D44212: devd: Document the nvme devd events.

Harbormaster completed remote builds in B56432: Diff 135375.Mar 4 2024, 11:49 PM

imp added reviewers: chuck, jhb, mav.Mar 4 2024, 11:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2024, 1:40 AM

Closed by commit rG5cdedf676d03: nvme: Log reset success or failure to devd (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG5cdedf676d03: nvme: Log reset success or failure to devd.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

7 lines

Diff 135375

sys/dev/nvme/nvme_ctrlr.c

Loading...