Page MenuHomeFreeBSD
Differential D43906

loader: Move to using linker sets to bring in optional bits
ClosedPublic
Actions

Authored by imp on Feb 14 2024, 9:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 8:47 PM
Unknown Object (File)
Mon, Nov 3, 8:47 PM
Unknown Object (File)
Mon, Nov 3, 8:46 PM
Unknown Object (File)
Mon, Nov 3, 8:46 PM
Unknown Object (File)
Mon, Nov 3, 8:45 PM
Unknown Object (File)
Wed, Oct 29, 6:49 PM
Unknown Object (File)
Sat, Oct 25, 12:12 AM
Unknown Object (File)
Thu, Oct 23, 1:49 PM
View All 94 Files
Subscribers
dab
jhb

Details

Reviewers
kevans
tsoome
manu
jhb
Commits
rG94e1374b55c7: loader: Move to using linker sets to bring in optional bits
rG0921a771da8a: loader: Move to using linker sets to bring in optional bits
Summary

The graphics stuff is optional. When it is pulled into the system, we
use a linker set to initialize the lua bindings for it now.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56030
Build 52919: arc lint + arc unit

Event Timeline

imp created this revision.Feb 14 2024, 9:53 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 14 2024, 9:53 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Feb 14 2024, 9:53 PM
Harbormaster completed remote builds in B56024: Diff 134352.Feb 14 2024, 9:53 PM
imp added a parent revision: D43905: loader: Remove gfx_fb_stub.c, it's no longer needed.Feb 14 2024, 9:53 PM
imp added a child revision: D43907: loader: Move gfx functions to gfx.lua.8.
jhb accepted this revision.Feb 14 2024, 10:00 PM
jhb added a subscriber: jhb.
jhb added inline comments.
stand/liblua/lutils.h
38
39

Maybe define a LUA_COMPILE_FOREACH here as a wrapper around SET_FOREACH so that the Xficl_compile_set name is all isolated to here and not also present in interp_lua.c?

This revision is now accepted and ready to land.Feb 14 2024, 10:00 PM
imp updated this revision to Diff 134367.Feb 15 2024, 12:05 AM

Use LUA_FOREACH_SET

This revision now requires review to proceed.Feb 15 2024, 12:05 AM
Harbormaster completed remote builds in B56030: Diff 134367.Feb 15 2024, 12:05 AM
kevans accepted this revision.Feb 15 2024, 12:41 AM
This revision is now accepted and ready to land.Feb 15 2024, 12:41 AM
Closed by commit rG0921a771da8a: loader: Move to using linker sets to bring in optional bits (authored by imp). · Explain WhyFeb 16 2024, 4:01 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG0921a771da8a: loader: Move to using linker sets to bring in optional bits.
imp added a commit: rG94e1374b55c7: loader: Move to using linker sets to bring in optional bits.Apr 16 2024, 8:13 PM

Revision Contents
Changeset List

PathSize
stand/
common/
29 lines
liblua/
27 lines
9 lines

Diff 134367

View Options

stand/common/interp_lua.c

Loading...
View Options

stand/liblua/gfx_utils.c

Loading...
View Options

stand/liblua/lutils.h

Loading...