pkgbase: Don't run scripts for some package types
AbandonedPublic
Actions

Authored by markj on Jan 25 2024, 7:03 PM.

Details

Reviewers

Group Reviewers

Summary

See bugzilla PR 276115. Most base system packages have several
auxilliary packages. In general, if the package has a post-install
script, the auxilliary packages do not need to also run it.

Guard package scripts with a test so that it's possible to disable them
at package creation time. Do so for all -dev, -dbg, -man, -lib32
package types. If individual packages want to override this behaviour,
they can be more selective in their use of the %RUNSCRIPTS% guard.

PR: 276115

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55608
Build 52497: arc lint + arc unit

Event Timeline

markj created this revision.Jan 25 2024, 7:03 PM

Herald added subscribers: jrtc27, emaste, imp. · View Herald TranscriptJan 25 2024, 7:03 PM

markj requested review of this revision.Jan 25 2024, 7:03 PM

Harbormaster completed remote builds in B55608: Diff 133355.Jan 25 2024, 7:03 PM

This ensures that we don't do things like run certctl hash when certctl-man is upgraded, or run kldxref when kernel debug symbols are upgraded. While these redundant scripts are harmless, they slow down upgrades and are somewhat surprising.

(Only build-tested so far.)

garga added a subscriber: garga.Jan 25 2024, 7:13 PM

If that works I think that the easiest approch.
Why was the comment lines on the top of the file deleted though ?

I haven't tested but I think we can have a simpler approach by using

.include(try=true) " "%PKG_NAME_PREFIX%-%PKGNAME%.script"

And move the whole scripts: {} block into certctl.script

In D43593#994484, @bapt wrote:
I haven't tested but I think we can have a simpler approach by using
.include(try=true) " "%PKG_NAME_PREFIX%-%PKGNAME%.script"
And move the whole scripts: {} block into certctl.script

It almost work I need to privide the full path and not relative path for it to work, I should have a proposal ASAP

bapt committed something better in f8e46fd61e055fcc767c2038d867f58c38e43ec3