Page MenuHomeFreeBSD
Differential D43524

copy_file_range: Call vn_rdwr() even for zero-length files
ClosedPublic
Actions

Authored by markj on Jan 20 2024, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 12, 1:00 AM
Unknown Object (File)
Wed, Sep 30, 7:22 PM
Unknown Object (File)
Sat, Sep 26, 6:05 PM
Unknown Object (File)
Sep 13 2026, 1:24 PM
Unknown Object (File)
Sep 11 2026, 12:22 AM
Unknown Object (File)
Sep 9 2026, 11:51 PM
Unknown Object (File)
Sep 8 2026, 11:00 AM
Unknown Object (File)
Sep 6 2026, 3:52 PM
View All Files
Subscribers
des
imp

Details

Reviewers
asomers
kib
rmacklem
olce
Commits
rGe3b27cc3546f: copy_file_range: Call vn_rdwr() at least once
rG08f3d5b60cdf: copy_file_range: Call vn_rdwr() at least once
Summary

This ensures that we invoke VOP_READ on the input file even if it's
empty, which in turn helps ensure that filesystems update the atime of
the file.

PR: 274615

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55512
Build 52401: arc lint + arc unit

Event Timeline

markj created this revision.Jan 20 2024, 5:29 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 20 2024, 5:29 PM
markj requested review of this revision.Jan 20 2024, 5:29 PM
Harbormaster completed remote builds in B55512: Diff 133096.Jan 20 2024, 5:29 PM
kib accepted this revision.Jan 20 2024, 6:45 PM
This revision is now accepted and ready to land.Jan 20 2024, 6:45 PM
olce accepted this revision.Jan 20 2024, 8:06 PM
rmacklem accepted this revision.Jan 20 2024, 9:09 PM

Looks ok to me.

des added a subscriber: des.Apr 3 2024, 2:48 PM

Needs rebasing but passes the additional test from D44609.

des added inline comments.Apr 3 2024, 2:50 PM
sys/kern/vfs_vnops.c
3573

Instead of adding a flag, you could simply switch from while to do-while.

markj added inline comments.Apr 3 2024, 3:39 PM
sys/kern/vfs_vnops.c
3573

It's not that simple - we could have interrupted != 0 before the first iteration.

Closed by commit rG08f3d5b60cdf: copy_file_range: Call vn_rdwr() at least once (authored by markj). · Explain WhyApr 4 2024, 9:17 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG08f3d5b60cdf: copy_file_range: Call vn_rdwr() at least once.
markj added a commit: rGe3b27cc3546f: copy_file_range: Call vn_rdwr() at least once.May 8 2024, 1:08 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
16 lines

Diff 133096

View Options

sys/kern/vfs_vnops.c

Loading...