file: Use the right fd in fgetvp_lookup()
ClosedPublic
Actions

Authored by markj on Dec 31 2023, 4:33 PM.

Details

Reviewers

mjg
kib

Commits

rGc2b07a75af21: file: Remove the fd parameter to fgetvp_lookup() and fgetvp_lookup_smr()
rG55edc40e0c75: file: Remove the fd parameter to fgetvp_lookup() and fgetvp_lookup_smr()

Summary

This is a no-op for now since the sole caller passes fd=ndp->ni_dirfd,
but the old code was still wrong. For some reason I do not see a
warning about "fd" being unused.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55182
Build 52071: arc lint + arc unit

Event Timeline

markj created this revision.Dec 31 2023, 4:33 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 31 2023, 4:33 PM

markj requested review of this revision.Dec 31 2023, 4:33 PM

Harbormaster completed remote builds in B55176: Diff 132041.Dec 31 2023, 4:33 PM

What is the expected semantic for the case of fd != ndp->ni_dirfd?

My first reaction to the patch was to propose removing the fd argument instead.

In D43257#985958, @kib wrote:

What is the expected semantic for the case of fd != ndp->ni_dirfd?

Indeed, it does not make much sense.

My first reaction to the patch was to propose removing the fd argument instead.

Same for fgetvp_lookup_smr() then, I suppose?

In D43257#985970, @markj wrote:

In D43257#985958, @kib wrote:

My first reaction to the patch was to propose removing the fd argument instead.

Same for fgetvp_lookup_smr() then, I suppose?

Definitely. Also perhaps it is time to remove the CAPABILITIES option.

In D43257#985983, @kib wrote:

In D43257#985970, @markj wrote:

In D43257#985958, @kib wrote:

My first reaction to the patch was to propose removing the fd argument instead.

Same for fgetvp_lookup_smr() then, I suppose?

Definitely. Also perhaps it is time to remove the CAPABILITIES option.

I'm for it. There was this attempt which apparently failed: D10776. The reasons are probably mostly gone since arm64's compat32 support has evolved and mips is gone. Maybe @oshogbo or @emaste have an opinion on this?