mcast: fix leaked igmp packets on multicast cleanup
ClosedPublic
Actions

Authored by kp on Dec 13 2023, 1:01 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG88e1bc06692a: mcast: fix leaked igmp packets on multicast cleanup
rGc2e340452c14: mcast: fix leaked igmp packets on multicast cleanup

Summary

When we release a multicast address (e.g. on interface shutdown) we may
still have packets queued in inm_scq. We have to free those, or we'll
leak memory.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54915
Build 51804: arc lint + arc unit

Event Timeline

kp created this revision.Dec 13 2023, 1:01 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptDec 13 2023, 1:01 PM

kp requested review of this revision.Dec 13 2023, 1:01 PM

kp added a parent revision: D43032: Revert "mcast: fix memory leak in imf_purge()".

Harbormaster completed remote builds in B54915: Diff 131327.Dec 13 2023, 1:02 PM

Isn't IPv6 part affected too?

Move mbufq_drain() to the same place as in the IPv6 code.

Harbormaster completed remote builds in B54952: Diff 131445.Dec 14 2023, 4:08 PM

In D43033#981649, @ae wrote:

Isn't IPv6 part affected too?

So that's an interesting point. It turns out that it's not, because in in6m_purge() we do call mbufq_drain(&inm->in6m_scq);.
I've moved my change to match what we do in IPv6.

glebius accepted this revision as: glebius.Dec 14 2023, 5:29 PM

This revision is now accepted and ready to land.Dec 14 2023, 5:29 PM

Closed by commit rGc2e340452c14: mcast: fix leaked igmp packets on multicast cleanup (authored by kp). · Explain WhyDec 14 2023, 10:00 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGc2e340452c14: mcast: fix leaked igmp packets on multicast cleanup.

imp added a commit: rG88e1bc06692a: mcast: fix leaked igmp packets on multicast cleanup.Aug 26 2024, 3:52 PM