src
ClosedPublic
Actions

Authored by bapt on Nov 13 2023, 5:19 PM.

Details

Reviewers

emaste
jhb

Group Reviewers

pkgbase

Commits

rG7b68016c7678: pkgbase: set the prefix of debug files and macros to /usr/src
rG7cedaf50721b: pkgbase: set the prefix of debug files and macros to /usr/src
rG030af1b62d7b: pkgbase: set the prefix of debug files and macros to /usr/src

Summary

When the macro PACKAGE_BUILDING is set, then consider we are building package for pkgbase, this has already been used in Makefile.inc1 and reuse the PACKAGE_BUILDING macros already used for that purpose in the ports tree

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54392
Build 51282: arc lint + arc unit

Event Timeline

bapt created this revision.Nov 13 2023, 5:19 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptNov 13 2023, 5:19 PM

bapt requested review of this revision.Nov 13 2023, 5:19 PM

Harbormaster completed remote builds in B54392: Diff 130023.Nov 13 2023, 5:19 PM

bapt added a reviewer: pkgbase.Nov 13 2023, 5:19 PM

bapt added reviewers: emaste, jhb.

bapt edited the summary of this revision. (Show Details)Nov 13 2023, 5:23 PM

This should be set in general for reproducible builds, to be honest, of which pkgbase is but one user.

I am fine with binding on the reproducible build variable

I agree with @jrtc27 that tying it to reproducible builds is sensible -- I'm fine with either change.
I'd like to understand the full workflow with gdb and lldb better.

This revision is now accepted and ready to land.Nov 13 2023, 7:17 PM

Closed by commit rG030af1b62d7b: pkgbase: set the prefix of debug files and macros to /usr/src (authored by bapt). · Explain WhyNov 14 2023, 7:43 AM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG030af1b62d7b: pkgbase: set the prefix of debug files and macros to /usr/src.

manu added a commit: rG7cedaf50721b: pkgbase: set the prefix of debug files and macros to /usr/src.Dec 2 2023, 9:45 AM

bapt added a commit: rG7b68016c7678: pkgbase: set the prefix of debug files and macros to /usr/src.Dec 4 2023, 10:40 AM

It turns out that when poudriere jail is run with -b, the PACKAGE_BUILDING isn't defined: https://github.com/freebsd/poudriere/issues/1196

On the other hand, why wrap these CFLAGS into .if (PACKAGE_BUILDING) at all? It feels to me that these flags are correct for any case.

this is not for all case because people may have multiple checkouts of the source tree (other than /usr/src) this is good only for releases.

Revision Contents
Changeset List

Path

Size

share/

mk/

src.sys.mk

3 lines

Diff 130023

View Options

pkgbase: set the prefix of debug files and macros to /usr/srcClosedPublicActions