Page MenuHomeFreeBSD

arm64: Initialize x18 for APs earlier during boot
ClosedPublic

Authored by markj on Nov 9 2023, 7:14 PM.
Tags
None
Referenced Files
F101858003: D42533.id130015.diff
Mon, Nov 4, 7:11 PM
Unknown Object (File)
Thu, Oct 17, 1:20 PM
Unknown Object (File)
Wed, Oct 16, 2:44 AM
Unknown Object (File)
Mon, Oct 14, 6:44 AM
Unknown Object (File)
Sun, Oct 13, 7:57 AM
Unknown Object (File)
Sun, Oct 13, 7:57 AM
Unknown Object (File)
Wed, Oct 9, 11:19 PM
Unknown Object (File)
Wed, Oct 9, 11:35 AM
Subscribers

Details

Summary

When KMSAN is configured, the instrumentation inserts calls to
__msan_get_context_state() into all function prologues. The
implementation dereferences curthread and thus assumes that x18 points
to the PCPU area. This applies in particular to init_secondary(), which
currently is responsible for initializing x18 for APs.

Move initialization into locore to avoid this problem. No functional
change intended.

Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54356
Build 51246: arc lint + arc unit

Event Timeline

markj requested review of this revision.Nov 9 2023, 7:14 PM
This revision is now accepted and ready to land.Nov 9 2023, 11:27 PM
sys/arm64/arm64/locore.S
254–255

We can remove a pc-relative load & replace it with what is essentially an add. I have a local patch to clean up other places we use ldr, xn, =foo ldr xn, [xn].

markj marked an inline comment as done.

Apply Andy's suggestion

This revision now requires review to proceed.Nov 11 2023, 5:00 PM
This revision is now accepted and ready to land.Nov 12 2023, 3:57 PM