Paths

Table of Contentst

Differential D42467

if_tuntap: trigger the bpf hook on transmitting for the tap interface
ClosedPublic
Actions

Authored by tuexen on Nov 4 2023, 4:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 1, 9:05 PM

	Unknown Object (File)
	Mon, Jul 1, 1:24 PM

	Unknown Object (File)
	Mon, Jul 1, 12:25 PM

	Unknown Object (File)
	Sat, Jun 29, 12:12 AM

	Unknown Object (File)
	Sat, Jun 29, 12:09 AM

	Unknown Object (File)
	Sat, Jun 22, 6:52 AM

	Unknown Object (File)
	Fri, Jun 21, 6:18 AM

	Unknown Object (File)
	Jun 3 2024, 11:03 AM

View All 24 Files

Subscribers

Details

Reviewers

rscheff
kevans
rgrimes

Commits

rGf6aae554b076: if_tuntap: trigger the bpf hook on transmitting for the tap interface
rGe0f22f9e1867: if_tuntap: trigger the bpf hook on transmitting for the tap interface
rG35af22ac986c: if_tuntap: trigger the bpf hook on transmitting for the tap interface

Summary

The tun interface triggers the bpf hook when a packet is transmitted, the tap interface triggers it when the packet is read from the character device. This is inconsistent. So fix the tap device such that is behaves like the tun device. This is needed for adding support for the tap device to packetdrill.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Nov 4 2023, 4:34 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptNov 4 2023, 4:34 PM

tuexen requested review of this revision.Nov 4 2023, 4:34 PM

tuexen added a reviewer: rgrimes.Nov 4 2023, 5:02 PM

This looks appropriate to me.

This revision is now accepted and ready to land.Nov 5 2023, 1:00 PM

kevans accepted this revision.Nov 5 2023, 3:50 PM

Closed by commit rG35af22ac986c: if_tuntap: trigger the bpf hook on transmitting for the tap interface (authored by tuexen). · Explain WhyNov 5 2023, 7:37 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG35af22ac986c: if_tuntap: trigger the bpf hook on transmitting for the tap interface.

tuexen added a commit: rGe0f22f9e1867: if_tuntap: trigger the bpf hook on transmitting for the tap interface.Jan 12 2024, 4:53 PM

tuexen added a commit: rGf6aae554b076: if_tuntap: trigger the bpf hook on transmitting for the tap interface.Jan 12 2024, 5:53 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

15 lines

Diff 129722

sys/net/if_tuntap.c

Loading...