Differential D42001

Move the adding of CFLAGS_LAST to bsd.sys.mk
ClosedPublic
Actions

Authored by sjg on Sep 27 2023, 3:26 PM.

Details

Reviewers

stevek
imp
obrien

Commits

rGb45ab4b000b4: Move the adding of CFLAGS_LAST to bsd.sys.mk

Summary

The point of CFLAGS_LAST is to be the last thing in CFLAGS
so add it last.

For DIRDEPS_BUILD this can best be done via local.dirdeps-build.mk
which is guaranteed to be the last makefile read, but that does nothing
for non-DIRDEPS_BUILD

bsd.sys.mk is close enough to the end.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53746
Build 50637: arc lint + arc unit

Event Timeline

sjg created this revision.Sep 27 2023, 3:26 PM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptSep 27 2023, 3:26 PM

sjg requested review of this revision.Sep 27 2023, 3:26 PM

Harbormaster completed remote builds in B53746: Diff 127868.Sep 27 2023, 3:26 PM

obrien added a reviewer: obrien.Sep 27 2023, 7:17 PM

Looks good. This will solve issues when one of

${CWARNFLAGS:M*} ${CWARNFLAGS.${COMPILER_TYPE}} ${CWARNFLAGS.${.IMPSRC:T}} ${CFLAGS.${COMPILER_TYPE}} ${CFLAGS.${.IMPSRC:T}} ${CWARNFLAGS.${.TARGET:T}} ${CFLAGS.${.TARGET:T}}

needs to be overridden or tweaked; which current cannot be easily done due to CFLAGS_LAST appearing before them.

This revision is now accepted and ready to land.Sep 27 2023, 7:19 PM

Closed by commit rGb45ab4b000b4: Move the adding of CFLAGS_LAST to bsd.sys.mk (authored by sjg). · Explain WhySep 28 2023, 9:03 PM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rGb45ab4b000b4: Move the adding of CFLAGS_LAST to bsd.sys.mk.