Page MenuHomeFreeBSD
Differential D39450

Add BTI exceptions
ClosedPublic
Actions

Authored by andrew on Apr 6 2023, 4:09 PM.
Tags
None
Referenced Files
F153273763: D39450.diff
Mon, Apr 20, 4:38 AM
Unknown Object (File)
Sat, Apr 18, 6:44 PM
Unknown Object (File)
Thu, Apr 2, 1:27 AM
Unknown Object (File)
Sun, Mar 29, 10:00 AM
Unknown Object (File)
Sat, Mar 28, 7:59 PM
Unknown Object (File)
Sat, Mar 28, 2:35 AM
Unknown Object (File)
Mar 20 2026, 7:20 AM
Unknown Object (File)
Mar 19 2026, 3:20 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
kib
markj
manu
Group Reviewers
arm64
Commits
rG3e3e2ce55be3: Add BTI exceptions
rGed304b0be0df: Add BTI exceptions
rG450f731b7f23: Add BTI exceptions
Summary

We could hit these when executing code marked as using BTI but jumps
to a non-branch target instruction.

Sponsored by: Arm Ltd
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Apr 6 2023, 4:09 PM
Herald added a reviewer: manu. · View Herald TranscriptApr 6 2023, 4:09 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Apr 6 2023, 4:09 PM
andrew added a parent revision: D39449: Add per-arch flags to struct vm_map_entry.
Harbormaster completed remote builds in B50795: Diff 119947.Apr 6 2023, 4:09 PM
andrew added a child revision: D39451: Add BTI support to the arm64 pmap.Apr 6 2023, 4:09 PM
emaste added inline comments.Apr 6 2023, 4:29 PM
sys/arm64/arm64/trap.c
708

it's too bad there's not something like ILL_ILLBRANCH or such, but it looks like ILL_ILLOPC is consistent with Linux

kib added inline comments.Apr 7 2023, 3:32 AM
sys/arm64/arm64/trap.c
708

Nothing prevents us from adding specific si_value if it is useful.

imp added a comment.Apr 7 2023, 5:53 PM

This looks good to me... Will have to remember to check qemu's bsd-user to add this.

andrew added inline comments.Apr 7 2023, 7:31 PM
sys/arm64/arm64/trap.c
708

We set si_trapno to the exception number if userspace needs to know it's a BTI exception.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2023, 5:17 PM
Closed by commit rG450f731b7f23: Add BTI exceptions (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG450f731b7f23: Add BTI exceptions.
andrew added a commit: rGed304b0be0df: Add BTI exceptions.Feb 19 2024, 4:45 PM
andrew added a commit: rG3e3e2ce55be3: Add BTI exceptions.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
2 lines
10 lines
include/
1 line

Diff 127645

View Options

sys/arm64/arm64/locore.S

Loading...
View Options

sys/arm64/arm64/trap.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...