Page MenuHomeFreeBSD
Differential D41848

virtio: use bool for boolean functions
ClosedPublic
Actions

Authored by freebsd_igalic.co on Sep 13 2023, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 10:21 AM
Unknown Object (File)
Sun, Jun 23, 6:51 PM
Unknown Object (File)
Thu, Jun 20, 9:14 AM
Unknown Object (File)
Tue, Jun 18, 12:15 PM
Unknown Object (File)
Thu, Jun 6, 8:49 AM
Unknown Object (File)
Mar 13 2024, 6:34 PM
Unknown Object (File)
Jan 31 2024, 9:38 AM
Unknown Object (File)
Jan 30 2024, 2:47 AM
View All 20 Files
Subscribers
cognet
imp

Details

Reviewers
bryanv
Commits
rGccb576a83cc9: virtio: use bool for boolean functions
Summary

these static functions:

  • vq_ring_use_indirect

and these public functions:

  • virtio_bus_is_modern
  • virtio_with_feature
  • virtqueue_empty
  • virtqueue_full

exclusively return a boolean value.
Change their return values to bool.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53575
Build 50466: arc lint + arc unit

Event Timeline

freebsd_igalic.co created this revision.Sep 13 2023, 10:34 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 13 2023, 10:34 PM
freebsd_igalic.co requested review of this revision.Sep 13 2023, 10:34 PM
Harbormaster completed remote builds in B53575: Diff 127347.Sep 13 2023, 10:34 PM
freebsd_igalic.co added a child revision: D41849: virtio: add comment on the spec for vring struct.Sep 13 2023, 10:35 PM
freebsd_igalic.co added a reviewer: bryanv.Sep 13 2023, 11:17 PM
cognet added a subscriber: cognet.Sep 14 2023, 12:02 AM
cognet added inline comments.
sys/dev/virtio/pci/virtio_pci_legacy.c
90

Hmm those int arguments, disappearing from the virtqueues method, should probably not be removed in that commit :)

sys/dev/virtio/pci/virtio_pci_modern.c
115

ditto

freebsd_igalic.co added inline comments.Sep 14 2023, 12:09 AM
sys/dev/virtio/pci/virtio_pci_legacy.c
90

thanks for catching that.
looks like a botched rebase

freebsd_igalic.co updated this revision to Diff 127371.Sep 14 2023, 10:33 AM

thanks to @cognet for helping catch this rebase fuckup.

bryanv accepted this revision.Sep 15 2023, 3:45 AM
This revision is now accepted and ready to land.Sep 15 2023, 3:45 AM
Closed by commit rGccb576a83cc9: virtio: use bool for boolean functions (authored by freebsd_igalic.co, committed by cognet). · Explain WhySep 18 2023, 8:05 PM
This revision was automatically updated to reflect the committed changes.
cognet added a commit: rGccb576a83cc9: virtio: use bool for boolean functions.
freebsd_igalic.co added a comment.Sep 21 2023, 12:49 PM

I reckon this commit can easily be MFC'd without causing too much breakage

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
mmio/
4 lines
pci/
2 lines
2 lines
6 lines
6 lines
4 lines
4 lines
2 lines
4 lines
16 lines

Diff 127347

View Options

sys/dev/virtio/mmio/virtio_mmio.c

Loading...
View Options

sys/dev/virtio/pci/virtio_pci.h

Loading...
View Options

sys/dev/virtio/pci/virtio_pci.c

Loading...
View Options

sys/dev/virtio/pci/virtio_pci_legacy.c

Loading...
View Options

sys/dev/virtio/pci/virtio_pci_modern.c

Loading...
View Options

sys/dev/virtio/virtio.h

Loading...
View Options

sys/dev/virtio/virtio.c

Loading...
View Options

sys/dev/virtio/virtio_bus_if.m

Loading...
View Options

sys/dev/virtio/virtqueue.h

Loading...
View Options

sys/dev/virtio/virtqueue.c

Loading...