Page MenuHomeFreeBSD
Differential D5070

Support new MDIO hierarchy in ThunderX DTB
ClosedPublic
Actions

Authored by zbb on Jan 25 2016, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 7, 6:51 AM
Unknown Object (File)
Sat, Mar 7, 1:43 AM
Unknown Object (File)
Jan 1 2026, 5:14 AM
Unknown Object (File)
Dec 14 2025, 3:12 AM
Unknown Object (File)
Dec 11 2025, 3:22 AM
Unknown Object (File)
Dec 10 2025, 5:59 AM
Unknown Object (File)
Dec 8 2025, 12:10 PM
Unknown Object (File)
Dec 3 2025, 8:40 PM
View All Files
Subscribers
emaste
arm64

Details

Reviewers
wma
andrew
imp
• ian
Commits
rS294994: Support new MDIO hierarchy in ThunderX DTB
Summary

Some firmware revisions provide different DTB tree that include
odd MDIO placement in the tree.
This commit adds support for 2 new buses:

  • MRML bridge (PCIB subordinate)
  • MDIO nexus (MRML subordinate)

This allows for the correct MDIO attachment with both - new and old
firmware.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zbb updated this revision to Diff 12689.Jan 25 2016, 3:47 PM
zbb retitled this revision from to Support new MDIO hierarchy in ThunderX DTB.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: andrew, imp, • ian, wma.
zbb set the repository for this revision to rS FreeBSD src repository - subversion.
zbb added a subscriber: arm64.
Herald added a subscriber: emaste. · View Herald TranscriptJan 25 2016, 3:47 PM
zbb added a parent revision: D5069: Add FDT bus capabilities to ThunderX PCI driver.Jan 25 2016, 3:49 PM
zbb added inline comments.Jan 28 2016, 12:07 PM
sys/conf/files.arm64
74

I will add fdt dependency here in the final commit.

andrew added inline comments.Jan 28 2016, 12:21 PM
sys/dev/vnic/mrml_bridge.c
139

Change to use rman_res_t

162

device_get_softc returns a void *, there is no need to cast here.

250

Cast?

sys/dev/vnic/thunder_mdio_fdt.c
111

Why not just use this directly?

zbb added inline comments.Jan 28 2016, 12:33 PM
sys/dev/vnic/mrml_bridge.c
139

OK

162

It was done on purpose because the softc of this driver contains simplebus_softc. I wanted to make that clear that we extract the simplebus_softc only.

250

Same as above.

sys/dev/vnic/thunder_mdio_fdt.c
111

Yeah, this may simplify everything here.

andrew added inline comments.Jan 28 2016, 12:38 PM
sys/dev/vnic/mrml_bridge.c
162

Why not have this driver use simplebus_softc directly then?

zbb added inline comments.Jan 28 2016, 12:39 PM
sys/dev/vnic/mrml_bridge.c
162

As I wrote in a comment below - I agree.

zbb updated this revision to Diff 12790.Jan 28 2016, 1:11 PM
zbb marked 10 inline comments as done.Jan 28 2016, 1:13 PM
zbb marked an inline comment as done.
Closed by commit rS294994: Support new MDIO hierarchy in ThunderX DTB (authored by zbb). · Explain WhyJan 28 2016, 3:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
dev/
vnic/
284 lines
204 lines
1 line

Diff 12689

View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/vnic/mrml_bridge.c

Loading...
View Options

sys/dev/vnic/thunder_mdio_fdt.c

Loading...
View Options

sys/dev/vnic/thunder_mdio_var.h

Loading...