Page MenuHomeFreeBSD
Differential D41512

libc: Add unit tests for N2630 and possible collateral damage.
ClosedPublic
Actions

Authored by des on Aug 19 2023, 11:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 12:06 AM
Unknown Object (File)
Fri, Jan 17, 8:23 PM
Unknown Object (File)
Fri, Jan 17, 6:47 PM
Unknown Object (File)
Dec 12 2024, 1:04 AM
Unknown Object (File)
Dec 8 2024, 8:28 PM
Unknown Object (File)
Dec 2 2024, 8:00 AM
Unknown Object (File)
Nov 20 2024, 9:57 AM
Unknown Object (File)
Nov 20 2024, 9:56 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
ngie
imp
emaste
Commits
rGb9385720f34b: libc: Add unit tests for N2630 and possible collateral damage.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53213
Build 50104: arc lint + arc unit

Event Timeline

des created this revision.Aug 19 2023, 11:47 PM
Herald added a reviewer: ngie. · View Herald TranscriptAug 19 2023, 11:47 PM
Herald added a subscriber: imp. · View Herald Transcript
des requested review of this revision.Aug 19 2023, 11:47 PM
Harbormaster completed remote builds in B53177: Diff 126242.Aug 19 2023, 11:47 PM
des added a parent revision: D41511: libc: Implement N2630..Aug 19 2023, 11:47 PM
emaste added a subscriber: emaste.Aug 19 2023, 11:59 PM
imp accepted this revision.Aug 21 2023, 5:17 PM

Only issue I see, and it might not even be an issue, is assuming sizeof(int) == 4.

lib/libc/tests/stdio/snprintf_test.c
47

these assume 32-bit int. Is that sane wrt CHERI?

This revision is now accepted and ready to land.Aug 21 2023, 5:17 PM
emaste accepted this revision.Aug 21 2023, 5:27 PM

Tests lgtm, will leave it to @ngie to comment on the netbsd-tests changes/approach.

des updated this revision to Diff 126331.Aug 21 2023, 9:23 PM

A few more cases.

This revision now requires review to proceed.Aug 21 2023, 9:23 PM
Harbormaster completed remote builds in B53213: Diff 126331.Aug 21 2023, 9:23 PM
des updated this revision to Diff 126552.Aug 26 2023, 5:09 PM

Improve sscanf() tests.

Harbormaster completed remote builds in B53301: Diff 126552.Aug 26 2023, 5:09 PM
des updated this revision to Diff 126557.Aug 26 2023, 6:29 PM

Fully test sscanf() and swscanf() changes.

Harbormaster completed remote builds in B53303: Diff 126557.Aug 26 2023, 6:29 PM
imp accepted this revision.Aug 28 2023, 3:28 PM

These look good to me, though I did not verify the tables were right

This revision is now accepted and ready to land.Aug 28 2023, 3:28 PM
Closed by commit rGb9385720f34b: libc: Add unit tests for N2630 and possible collateral damage. (authored by des). · Explain WhyAug 28 2023, 3:39 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGb9385720f34b: libc: Add unit tests for N2630 and possible collateral damage..
des mentioned this in rGbae932999e0f: libc: Implement N2630..Sep 7 2023, 8:29 PM

Revision Contents
Changeset List

PathSize
contrib/
netbsd-tests/
lib/
libc/
stdlib/
6 lines
lib/
libc/
tests/
stdio/
2 lines
138 lines
117 lines

Diff 126331

View Options

contrib/netbsd-tests/lib/libc/stdlib/t_strtol.c

Loading...
View Options

lib/libc/tests/stdio/Makefile

Loading...
View Options

lib/libc/tests/stdio/snprintf_test.c

Loading...
View Options

lib/libc/tests/stdio/sscanf_test.c

Loading...