Page MenuHomeFreeBSD

libc: Add unit tests for N2630 and possible collateral damage.
ClosedPublic

Authored by des on Aug 19 2023, 11:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 13, 4:39 AM
Unknown Object (File)
Sun, Jul 7, 2:52 PM
Unknown Object (File)
Sun, Jul 7, 7:09 AM
Unknown Object (File)
Fri, Jul 5, 8:30 PM
Unknown Object (File)
Mon, Jul 1, 8:54 PM
Unknown Object (File)
Sun, Jun 30, 3:35 AM
Unknown Object (File)
Sat, Jun 29, 1:59 PM
Unknown Object (File)
Sat, Jun 29, 7:23 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53213
Build 50104: arc lint + arc unit

Event Timeline

des requested review of this revision.Aug 19 2023, 11:47 PM

Only issue I see, and it might not even be an issue, is assuming sizeof(int) == 4.

lib/libc/tests/stdio/snprintf_test.c
47

these assume 32-bit int. Is that sane wrt CHERI?

This revision is now accepted and ready to land.Aug 21 2023, 5:17 PM

Tests lgtm, will leave it to @ngie to comment on the netbsd-tests changes/approach.

This revision now requires review to proceed.Aug 21 2023, 9:23 PM

Fully test sscanf() and swscanf() changes.

These look good to me, though I did not verify the tables were right

This revision is now accepted and ready to land.Aug 28 2023, 3:28 PM