Free allocated per-CPU structures in the pcpu_fini and finalize methods.
While here, add debug trace entries to these methods.
Details
Details
- Reviewers
jkoshy andrew gnn - Group Reviewers
pmc - Commits
- rGdd70f2b48c9c: hwpmc_arm64: plug memory leak
rG8bdceaecabd9: hwpmc_arm64: plug memory leak
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 52926 Build 49817: arc lint + arc unit
Event Timeline
| sys/dev/hwpmc/hwpmc_arm64.c | ||
|---|---|---|
| 453 | FYI this just makes it consistent with the trace entry I am adding. There is no need to encode cpu in the message, as every ktr record contains this value, and it is always true that cpu == curcpu for this function. | |
| sys/dev/hwpmc/hwpmc_arm64.c | ||
|---|---|---|
| 496–498 | I think this would be safer if we moved it after disabling the PMC. | |