pf: use sctp_calculate_cksum()
ClosedPublic
Actions

Authored by kp on Jul 7 2023, 2:38 PM.

Details

Reviewers

None

Group Reviewers

network

Commits

rG836dc3507e0d: pf: use sctp_calculate_cksum()
rG61e22e9b2905: pf: use sctp_calculate_cksum()

Summary

This function is always available, even if the SCTP or SCTP_SUPPORT options
are not set.
That lets us remove an ifdef, and also means we improve pf's SCTP handling
when the options are not set.

MFC after: 3 weeks
Sponsored by: Orange Business Services

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jul 7 2023, 2:38 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptJul 7 2023, 2:38 PM

kp requested review of this revision.Jul 7 2023, 2:38 PM

Harbormaster completed remote builds in B52479: Diff 124282.Jul 7 2023, 2:38 PM

kp added a child revision: D40861: pfctl: SCTP can have port numbers.Jul 7 2023, 2:39 PM

emaste mentioned this in D41111: status 2023q3: add pf status report.Jul 20 2023, 5:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2023, 10:33 AM

Closed by commit rG61e22e9b2905: pf: use sctp_calculate_cksum() (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG61e22e9b2905: pf: use sctp_calculate_cksum().

kp added a commit: rG836dc3507e0d: pf: use sctp_calculate_cksum().Aug 11 2023, 12:13 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

22 lines

Diff 124970

View Options

sys/netpfil/pf/pf.c

Context not available.
	*/	*/
	arm_smccc_1_0 hvc	arm_smccc_1_0 hvc
	arm_smccc_1_0 smc	arm_smccc_1_0 smc
		/* arm_smccc_1_2_hvc(const struct arm_smccc_1_2_regs *args,
		struct arm_smccc_1_2_regs res) /
		andrewUnsubmitted Done Inline Actions You can remove this comment & replace it with a newline to seperate the above from the 1.2 macro. andrew: You can remove this comment & replace it with a newline to seperate the above from the 1.2…
		.macro arm_smccc_1_2 insn
		ENTRY(arm_smccc_1_2_\insn)
		stp x1, x19, [sp, #-16]!
		mov x19, x0
		ldp x0, x1, [x19, #16 * 0]
		ldp x2, x3, [x19, #16 * 1]
		ldp x4, x5, [x19, #16 * 2]
		ldp x6, x7, [x19, #16 * 3]
		ldp x8, x9, [x19, #16 * 4]
		andrewUnsubmitted Done Inline Actions Can you rebase this past R10:48a7e53db78293ba2723cecfb3a3d5d23ea8e44d & update to be a macro so we can also add `smc` support. andrew: Can you rebase this past R10:48a7e53db78293ba2723cecfb3a3d5d23ea8e44d & update to be a macro so…
		ldp x10, x11, [x19, #16 * 5]
		ldp x12, x13, [x19, #16 * 6]
		ldp x14, x15, [x19, #16 * 7]
		ldp x16, x17, [x19, #16 * 8]
		hvc #0
		andrewUnsubmitted Done Inline Actions `\insn #0` andrew: `\insn #0`
		ldr x19, [sp]
		cbz x19, 1f
		stp x0, x1, [x19, #16 * 0]
		stp x2, x3, [x19, #16 * 1]
		lwhsuUnsubmitted Done Inline Actions Why two spaces between `,` and `[`? for those 3 lines? lwhsu: Why two spaces between `,` and `[`? for those 3 lines?
		stp x4, x5, [x19, #16 * 2]
		stp x6, x7, [x19, #16 * 3]
		stp x8, x9, [x19, #16 * 4]
		stp x10, x11, [x19, #16 * 5]
		stp x12, x13, [x19, #16 * 6]
		stp x14, x15, [x19, #16 * 7]
		stp x16, x17, [x19, #16 * 8]
		ldp xzr, x19, [sp], #16
		1: ret
		END(arm_smccc_1_2\insn)
		.endm
		/* int arm_smccc_1_2_(const struct arm_smccc_1_2_regs args,
		lwhsuUnsubmitted Done Inline Actions Also those 3 lines. lwhsu: Also those 3 lines.
		lwhsuUnsubmitted Not Done Inline Actions Small nit: trailing white space. lwhsu: Small nit: trailing white space.
		* struct arm_smccc_1_2_regs *res)
		*/
		arm_smccc_1_2 hvc
		arm_smccc_1_2 smc
Context not available.

pf: use sctp_calculate_cksum()ClosedPublicActions