Page MenuHomeFreeBSD
Differential D40841

rtld: Clear x29 for thread_start to conform Aarch64 ABI ps
ClosedPublic
Actions

Authored by dchagin on Jul 2 2023, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 9:53 PM
Unknown Object (File)
Sun, Nov 24, 8:31 PM
Unknown Object (File)
Sun, Nov 24, 1:47 PM
Unknown Object (File)
Sat, Nov 23, 9:32 PM
Unknown Object (File)
Sat, Nov 23, 4:51 AM
Unknown Object (File)
Fri, Nov 22, 4:21 PM
Unknown Object (File)
Fri, Nov 22, 10:28 AM
Unknown Object (File)
Thu, Nov 21, 6:19 PM
View All 78 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Commits
rG1a2aa2ffb502: rtld: Clear x29 and lr for thread_start to conform Aarch64 ABI pcs

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52388
Build 49279: arc lint + arc unit

Event Timeline

dchagin created this revision.Jul 2 2023, 3:32 PM
Herald added a reviewer: andrew. · View Herald TranscriptJul 2 2023, 3:32 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
dchagin requested review of this revision.Jul 2 2023, 3:32 PM
Harbormaster completed remote builds in B52382: Diff 124101.Jul 2 2023, 3:32 PM
dchagin updated this revision to Diff 124107.Jul 2 2023, 8:19 PM

Also clear lr,
strictly speaking, SYS V Aarch64 ABI does not states that lr should be
cleared, however gdb relies on it value and tryes to unwind stack further.

Harbormaster completed remote builds in B52388: Diff 124107.Jul 2 2023, 8:19 PM
dchagin mentioned this in D40620: libthr: Add an annotated _thread_start to satisfy unwinders on x86 and arm64.Jul 3 2023, 9:36 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 7 2023, 4:56 PM
Closed by commit rG1a2aa2ffb502: rtld: Clear x29 and lr for thread_start to conform Aarch64 ABI pcs (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG1a2aa2ffb502: rtld: Clear x29 and lr for thread_start to conform Aarch64 ABI pcs.
arichardson mentioned this in D46400: [RISC-V] Set ra to zero when calling into userspace.Aug 21 2024, 5:29 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
2 lines

Diff 124107

View Options

sys/arm64/arm64/vm_machdep.c

Loading...