Page MenuHomeFreeBSD

camdd: Remove some dead code but also try to make -E functional.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:34 PM.
Tags
None
Referenced Files
F151278313: D40666.diff
Tue, Apr 7, 7:06 AM
Unknown Object (File)
Mon, Apr 6, 5:20 PM
Unknown Object (File)
Sun, Apr 5, 6:30 AM
Unknown Object (File)
Mon, Mar 16, 6:06 PM
Unknown Object (File)
Mar 4 2026, 3:16 AM
Unknown Object (File)
Mar 4 2026, 3:04 AM
Unknown Object (File)
Feb 14 2026, 9:50 AM
Unknown Object (File)
Feb 9 2026, 2:04 AM
Subscribers

Details

Summary
  • Pass down the top-level arglist from main down to camdd_rw and use it in place of the hardcoded CAMDD_ARG_ERR_RECOVER when calling camdd_probe_pass. This now disables error recovery by default unless -E is specified.
  • Use the return value of parse_btl to determine if an explicit LUN was specified.
  • Remove most CAMDD_ARG_* flags that are only set and never checked. CAMDD_ARG_VERBOSE remains, but could perhaps be removed (and possibly -v should be removed as well since it is currently a no-op).

Reported by: clang -Wunused-but-set-variable (arglist in main)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable