Page MenuHomeFreeBSD

bsdinstall: Replace correct, but fragile, string builder with open_memstream.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
F166878300: D40658.id123533.diff
Mon, Aug 17, 11:17 AM
Unknown Object (File)
Wed, Aug 12, 10:30 PM
Unknown Object (File)
Wed, Aug 12, 10:30 PM
Unknown Object (File)
Wed, Aug 12, 10:30 PM
Unknown Object (File)
Wed, Aug 12, 10:30 PM
Unknown Object (File)
Tue, Aug 11, 10:35 PM
Unknown Object (File)
Tue, Aug 11, 10:23 PM
Unknown Object (File)
Mon, Aug 10, 7:35 AM
Subscribers

Details

Summary

The old one triggered a false positive -Warray-bounds from GCC (the
compiler assumed len was always 0), but it was also fragile with
manually computed lengths paired with strcat vs using a string
builder.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52193
Build 49084: arc lint + arc unit