Page MenuHomeFreeBSD

bsdinstall: Replace correct, but fragile, string builder with open_memstream.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
F171189782: D40658.id.diff
Wed, Sep 9, 9:26 AM
F171146063: D40658.diff
Wed, Sep 9, 12:15 AM
F171145768: D40658.diff
Wed, Sep 9, 12:11 AM
Unknown Object (File)
Mon, Sep 7, 9:01 PM
Unknown Object (File)
Sun, Sep 6, 6:50 PM
Unknown Object (File)
Sat, Sep 5, 2:22 PM
Unknown Object (File)
Fri, Sep 4, 9:04 PM
Unknown Object (File)
Thu, Sep 3, 1:53 PM
Subscribers

Details

Summary

The old one triggered a false positive -Warray-bounds from GCC (the
compiler assumed len was always 0), but it was also fragile with
manually computed lengths paired with strcat vs using a string
builder.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52193
Build 49084: arc lint + arc unit