Page MenuHomeFreeBSD

bsdinstall: Replace correct, but fragile, string builder with open_memstream.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
F157160540: D40658.id.diff
Mon, May 18, 9:43 PM
Unknown Object (File)
Mon, May 18, 10:18 AM
Unknown Object (File)
Sun, May 17, 10:00 PM
Unknown Object (File)
Sat, May 16, 2:12 PM
Unknown Object (File)
Fri, May 15, 8:17 AM
Unknown Object (File)
Wed, May 13, 10:23 PM
Unknown Object (File)
Wed, May 13, 10:16 PM
Unknown Object (File)
Wed, May 13, 10:15 PM
Subscribers

Details

Summary

The old one triggered a false positive -Warray-bounds from GCC (the
compiler assumed len was always 0), but it was also fragile with
manually computed lengths paired with strcat vs using a string
builder.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52193
Build 49084: arc lint + arc unit