Page MenuHomeFreeBSD
Differential D40654

ipfw: Remove set but unused variables.
ClosedPublic
Actions

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
F114672426: D40654.id123842.diff
Tue, Apr 15, 5:33 AM
Unknown Object (File)
Sun, Apr 13, 6:49 PM
Unknown Object (File)
Tue, Apr 1, 10:01 AM
Unknown Object (File)
Sat, Mar 29, 10:02 AM
Unknown Object (File)
Mar 10 2025, 7:17 PM
Unknown Object (File)
Jan 27 2025, 9:39 AM
Unknown Object (File)
Jan 27 2025, 9:31 AM
Unknown Object (File)
Jan 17 2025, 8:23 PM
View All 83 Files
Subscribers
donner
imp

Details

Reviewers
melifaro
Commits
rGf5e73306336f: ipfw: Remove set but unused variables.
Summary

Reported by: GCC

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52189
Build 49080: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
ipfw/
3 lines
3 lines
3 lines
3 lines
3 lines
6 lines

Diff 123529

View Options

sbin/ipfw/nat.c

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

sbin/ipfw/nat64clat.c

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

sbin/ipfw/nat64lsn.c

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

sbin/ipfw/nat64stl.c

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

sbin/ipfw/nptv6.c

Loading...
View Options

sbin/ipfw/tables.c

Loading...