bhyve/tpm: create crb thread for sending tpm commands
ClosedPublic
Actions

Authored by corvink on Jun 7 2023, 12:05 PM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG0daf5f02cfaf: bhyve/tpm: create crb thread for sending tpm commands

Summary

Commands send to a tpm are very slow. They can take up to several
seconds for completion. For that reason, create a thread which issues
the commands to the tpm device.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52135
Build 49026: arc lint + arc unit

Event Timeline

corvink created this revision.Jun 7 2023, 12:05 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJun 7 2023, 12:05 PM

corvink requested review of this revision.Jun 7 2023, 12:05 PM

Harbormaster completed remote builds in B51950: Diff 122925.Jun 7 2023, 12:05 PM

corvink added a child revision: D40459: bhyve/tpm: add emulation for crb register.Jun 7 2023, 12:09 PM

corvink added a parent revision: D40457: bhyve/tpm: build TPM2 table by tpm interface.

markj added inline comments.Jun 8 2023, 3:28 PM

usr.sbin/bhyve/tpm_intf_crb.c
214
296	The mutex and condvar don't get destroyed anywhere.
310	Why not just write `pthread_set_name_np(crb->thread, "tpm_intf_crb");`?
331	Don't you need to wake up the thread here?

destroy cond and mutex
wakeup thread on destroy

Harbormaster completed remote builds in B52135: Diff 123409.Jun 19 2023, 6:35 AM

corvink marked 3 inline comments as done.Jun 19 2023, 6:35 AM

markj accepted this revision as: markj.Jun 19 2023, 7:36 PM

markj added inline comments.

usr.sbin/bhyve/tpm_intf_crb.c
292	warn/warnx/warc/err/errx/errc always append a newline.
292	`pthread_*` returns an error number upon failure, so you can get a better error message with `warnc(error, "%s: failed to init mutex", __func__);`. Same below.