Paths

Table of Contentst

bhyve: add basic TPM emulation struct
ClosedPublic
Actions

Authored by corvink on Jun 7 2023, 12:05 PM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rGe09778575817: bhyve: add basic TPM emulation struct

Summary

This struct will be used to implement various TPM emulations like a TPM
passthrough or a virtual TPM.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Jun 7 2023, 12:05 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJun 7 2023, 12:05 PM

corvink requested review of this revision.Jun 7 2023, 12:05 PM

Harbormaster completed remote builds in B51946: Diff 122921.Jun 7 2023, 12:05 PM

corvink added a child revision: D40455: bhyve: add basic TPM passthrough emulation.Jun 7 2023, 12:09 PM

corvink added a parent revision: D40453: bhyve: register TPM device as ACPI device.

markj added inline comments.Jun 8 2023, 2:54 PM

usr.sbin/bhyve/tpm_device.c
88	Above you explicitly check for a missing "version" key, but not here. Why?
90	The opening brace should go on the previous line.
97

fix style issues

Harbormaster completed remote builds in B52075: Diff 123266.Jun 15 2023, 9:43 AM

corvink added a parent revision: D40558: bhyve: use assert for missing TPM version.Jun 15 2023, 9:44 AM

corvink removed a parent revision: D40453: bhyve: register TPM device as ACPI device.

corvink marked 3 inline comments as done.Jun 15 2023, 9:47 AM

corvink added inline comments.

usr.sbin/bhyve/tpm_device.c
88	Those keys should always be present. An explicit check is unnecessary. D40558 fixes it for the `version` key.

markj accepted this revision as: markj.Jun 15 2023, 3:11 PM

This revision is now accepted and ready to land.Jun 15 2023, 3:11 PM

Closed by commit rGe09778575817: bhyve: add basic TPM emulation struct (authored by corvink). · Explain WhyJun 16 2023, 6:23 AM

This revision was automatically updated to reflect the committed changes.

corvink marked an inline comment as done.

corvink added a commit: rGe09778575817: bhyve: add basic TPM emulation struct.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

tpm_device.c

29 lines

tpm_emul.h

22 lines

Diff 123321

View Options

usr.sbin/bhyve/tpm_device.c