Differential D40579

tcp: Disallow connecting a disconnected socket
ClosedPublic
Actions

Authored by markj on Jun 16 2023, 3:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 17, 11:15 AM

	Unknown Object (File)
	Mon, Jun 15, 10:03 PM

	Unknown Object (File)
	May 22 2026, 11:55 PM

	Unknown Object (File)
	May 19 2026, 1:13 AM

	Unknown Object (File)
	May 19 2026, 1:13 AM

	Unknown Object (File)
	May 19 2026, 1:11 AM

	Unknown Object (File)
	May 17 2026, 8:45 AM

	Unknown Object (File)
	May 16 2026, 10:10 AM

View All 98 Files

Subscribers

Details

Reviewers

glebius
bz

Group Reviewers

network
transport

Commits

rGde0a2eb2ef86: tcp: Disallow connecting a disconnected socket

Summary

Currently nothing prevents tcp_usr_connect() from attempting to connect
when the socket has been disconnected. At the moment, doing so triggers
an assertion in in_pcbconnect() because inp_faddr is not unspecified. I
believe this may have been caught in the past by TIMEWAIT checks, but
those are now removed.

Check for additional socket states in tcp_connect(). Add a regression
test for this case.

Reported by: syzbot+f0f7871ec5397602b446@syzkaller.appspotmail.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52106
Build 48997: arc lint + arc unit

Event Timeline

markj created this revision.Jun 16 2023, 3:23 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 16 2023, 3:23 PM

Herald added subscribers: melifaro, asomers, imp. · View Herald Transcript

markj requested review of this revision.Jun 16 2023, 3:23 PM

Harbormaster completed remote builds in B52106: Diff 123342.Jun 16 2023, 3:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 23 2023, 3:10 PM

Closed by commit rGde0a2eb2ef86: tcp: Disallow connecting a disconnected socket (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGde0a2eb2ef86: tcp: Disallow connecting a disconnected socket.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

3 lines

tests/

sys/

netinet/

socket_afinet.c

47 lines

Diff 123342

sys/netinet/tcp_usrreq.c

Loading...

tests/sys/netinet/socket_afinet.c

Loading...