Paths

Table of Contentst

Differential D40040

bhyve: read OpRegion address and size for GVT-d
ClosedPublic
Actions

Authored by corvink on May 10 2023, 12:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 13, 5:10 PM

	Unknown Object (File)
	Mon, May 13, 5:10 PM

	Unknown Object (File)
	Mon, May 13, 5:10 PM

	Unknown Object (File)
	Mon, May 13, 5:10 PM

	Unknown Object (File)
	Mon, May 13, 5:10 PM

	Unknown Object (File)
	Fri, May 10, 7:16 PM

	Unknown Object (File)
	Thu, May 2, 4:10 AM

	Unknown Object (File)
	Tue, Apr 23, 8:12 AM

View All 45 Files

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

Commits

rGb260e413b4b7: bhyve: read OpRegion address and size for GVT-d
rG6952b9d25e18: bhyve: read OpRegion address and size for GVT-d

Summary

The OpRegion provides some configuration bits and ACPI methods used by
some Intel drivers. The guest needs access to it. In the first step,
we're reading it's address and size.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.May 10 2023, 12:45 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 10 2023, 12:45 PM

corvink requested review of this revision.May 10 2023, 12:45 PM

Harbormaster completed remote builds in B51414: Diff 121796.May 10 2023, 12:45 PM

corvink added a child revision: D40041: bhyve: copy OpRegion into guest memory.May 10 2023, 12:51 PM

corvink added a parent revision: D40039: bhyve: read out graphics stolen memory address and size.

markj added inline comments.May 10 2023, 5:49 PM

usr.sbin/bhyve/pci_gvt-d.c
191	It can't be O_RDONLY?
224	`memfd` is leaked here, no? We should be able to close it after mapping the header, I believe. In general we don't want to leave a `fd` for /dev/mem lying around.

don't leak memfd
open memfd readonly

Harbormaster completed remote builds in B51442: Diff 121847.May 11 2023, 10:38 AM

corvink added a parent revision: D40060: bhyve: emulate graphics stolen memory register.May 11 2023, 10:39 AM

corvink removed a parent revision: D40039: bhyve: read out graphics stolen memory address and size.

corvink added a parent revision: D40037: bhyve: import OpRegion definitions.May 11 2023, 12:32 PM

markj added inline comments.May 11 2023, 2:55 PM

usr.sbin/bhyve/pci_gvt-d.c
209
211
213	The header is guaranteed to be page-aligned?

corvink added inline comments.May 12 2023, 12:17 PM

usr.sbin/bhyve/pci_gvt-d.c
213	No, it doesn't have to be page aligned. On my systems it has an offset of +0x18 to page boundary. Don't know why.

don't return errno
make use of warn instead of warnx

Harbormaster completed remote builds in B51469: Diff 121907.May 12 2023, 12:24 PM

corvink marked 4 inline comments as done.May 12 2023, 12:24 PM

@jhb @markj Any additional comments?

jhb accepted this revision.Jun 7 2023, 6:35 PM

This revision is now accepted and ready to land.Jun 7 2023, 6:35 PM

Closed by commit rG6952b9d25e18: bhyve: read OpRegion address and size for GVT-d (authored by corvink). · Explain WhyJun 16 2023, 6:15 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG6952b9d25e18: bhyve: read OpRegion address and size for GVT-d.

corvink added a commit: rGb260e413b4b7: bhyve: read OpRegion address and size for GVT-d.Aug 18 2023, 7:43 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

67 lines

Diff 123317

usr.sbin/bhyve/pci_gvt-d.c

Loading...