Page MenuHomeFreeBSD
Differential D40037

bhyve: import OpRegion definitions
ClosedPublic
Actions

Authored by corvink on May 10 2023, 12:45 PM.
Tags
None
Referenced Files
F160894527: D40037.id121896.diff
Sun, Jun 28, 7:39 PM
Unknown Object (File)
Tue, Jun 23, 4:51 AM
Unknown Object (File)
Thu, Jun 18, 10:32 PM
Unknown Object (File)
Thu, Jun 18, 1:14 PM
Unknown Object (File)
Mon, Jun 8, 3:23 AM
Unknown Object (File)
May 19 2026, 11:07 PM
Unknown Object (File)
May 17 2026, 9:59 AM
Unknown Object (File)
May 17 2026, 8:33 AM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rG6ae7ed9e3854: bhyve: import OpRegion definitions
rGb67f0d360b87: bhyve: import OpRegion definitions
Summary

Those definitions are required for the GVT-d emulation to parse the
OpRegion.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.May 10 2023, 12:45 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 10 2023, 12:45 PM
corvink requested review of this revision.May 10 2023, 12:45 PM
Harbormaster completed remote builds in B51411: Diff 121793.May 10 2023, 12:45 PM
corvink added a child revision: D40038: bhyve: add empty GVT-d emulation.May 10 2023, 12:51 PM
corvink added a parent revision: D40036: bhyve: add helper for passthru specific mmio ranges.
markj added inline comments.May 10 2023, 2:50 PM
usr.sbin/bhyve/pci_gvt-d.h
5 ↗(On Diff #121793)

This file comes directly from edk2, but is missing the corresponding copyright header.

35 ↗(On Diff #121793)

Please use __packed, to be consistent with the rest of bhyve.

corvink updated this revision to Diff 121842.May 11 2023, 10:35 AM
  • use copyright header from edk2
  • make use of __packed instead of pragma pack
Harbormaster completed remote builds in B51437: Diff 121842.May 11 2023, 10:35 AM
corvink edited child revisions, added: D40040: bhyve: read OpRegion address and size for GVT-d; removed: D40038: bhyve: add empty GVT-d emulation.May 11 2023, 12:32 PM
corvink removed a parent revision: D40036: bhyve: add helper for passthru specific mmio ranges.
markj accepted this revision as: markj.May 11 2023, 2:37 PM
This revision is now accepted and ready to land.May 11 2023, 2:37 PM
Closed by commit rGb67f0d360b87: bhyve: import OpRegion definitions (authored by corvink). · Explain WhyMay 12 2023, 7:49 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rGb67f0d360b87: bhyve: import OpRegion definitions.
corvink added a commit: rG6ae7ed9e3854: bhyve: import OpRegion definitions.Aug 18 2023, 7:43 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
186 lines

Diff 121896

View Options

usr.sbin/bhyve/pci_gvt-d-opregion.h

Loading...