bhyve: add helper for passthru specific mmio ranges
ClosedPublic
Actions

Authored by corvink on May 10 2023, 12:45 PM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG7ffa1d667f74: bhyve: add helper for passthru specific mmio ranges
rG93cf93179c50: bhyve: add helper for passthru specific mmio ranges

Summary

Intel GPUs have two special memory regions. They are called Graphics
Stolen Memory and OpRegion. bhyve has to emulate both of them. In order
to keep track of those special regions, add generic mmio ranges to the
passthru emulation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.May 10 2023, 12:45 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 10 2023, 12:45 PM

corvink requested review of this revision.May 10 2023, 12:45 PM

Harbormaster completed remote builds in B51410: Diff 121792.May 10 2023, 12:45 PM

corvink added a child revision: D40037: bhyve: import OpRegion definitions.May 10 2023, 12:51 PM

corvink added a parent revision: D40035: bhyve: make passthru sel public available.

markj added inline comments.May 10 2023, 2:46 PM

usr.sbin/bhyve/pci_passthru.h
18	Is something meant to dereference these pointers? If not, why are they pointer types? It looks like they should be integer types.

corvink marked an inline comment as done.May 11 2023, 10:17 AM

corvink added inline comments.

usr.sbin/bhyve/pci_passthru.h
18	I'm using this pointer to map and copy the OpRegion. See D40041.

corvink edited child revisions, added: D40039: bhyve: read out graphics stolen memory address and size; removed: D40037: bhyve: import OpRegion definitions.May 11 2023, 12:32 PM

corvink removed a parent revision: D40035: bhyve: make passthru sel public available.

markj accepted this revision as: markj.May 11 2023, 2:37 PM

This revision is now accepted and ready to land.May 11 2023, 2:37 PM

Closed by commit rG93cf93179c50: bhyve: add helper for passthru specific mmio ranges (authored by corvink). · Explain WhyMay 12 2023, 7:49 AM

This revision was automatically updated to reflect the committed changes.

corvink marked an inline comment as done.

corvink added a commit: rG93cf93179c50: bhyve: add helper for passthru specific mmio ranges.

corvink added a commit: rG7ffa1d667f74: bhyve: add helper for passthru specific mmio ranges.Aug 18 2023, 7:43 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_passthru.h

10 lines

pci_passthru.c

12 lines

Diff 121895

View Options

usr.sbin/bhyve/pci_passthru.h