Page MenuHomeFreeBSD
Differential D40363

dtrace: deduplicate arm64 breakpoint definition
ClosedPublic
Actions

Authored by christos on May 31 2023, 7:45 PM.
Tags
None
Referenced Files
F151315968: D40363.id122680.diff
Tue, Apr 7, 1:23 PM
F151222068: D40363.diff
Mon, Apr 6, 11:04 PM
Unknown Object (File)
Sun, Apr 5, 3:33 PM
Unknown Object (File)
Sun, Apr 5, 10:50 AM
Unknown Object (File)
Fri, Mar 27, 5:33 AM
Unknown Object (File)
Tue, Mar 17, 9:56 AM
Unknown Object (File)
Sun, Mar 15, 3:48 PM
Unknown Object (File)
Tue, Mar 10, 10:30 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
markj
mhorne
gnn
Commits
rGbab7781e78fc: dtrace: deduplicate arm64 breakpoint definition

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51817
Build 48708: arc lint + arc unit

Event Timeline

christos created this revision.May 31 2023, 7:45 PM
Herald added a reviewer: gnn. · View Herald TranscriptMay 31 2023, 7:45 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
christos requested review of this revision.May 31 2023, 7:45 PM
Harbormaster completed remote builds in B51817: Diff 122680.May 31 2023, 7:45 PM
christos added a child revision: D40337: kinst: port to arm64.EditedMay 31 2023, 7:45 PM

I'm not really sure about the names. Maybe BRK_INSTR would be better than BRK?

christos mentioned this in D40337: kinst: port to arm64.May 31 2023, 7:56 PM
christos updated this revision to Diff 122681.May 31 2023, 8:15 PM

Diff against main, not my local branch.

Harbormaster completed remote builds in B51818: Diff 122681.May 31 2023, 8:15 PM
christos retitled this revision from dtrace: deduplicate ARM64 breakpoint definition to dtrace: deduplicate arm64 breakpoint definition.May 31 2023, 8:24 PM
markj added a comment.Jun 2 2023, 4:36 PM
In D40363#918888, @christos wrote:

I'm not really sure about the names. Maybe BRK_INSTR would be better than BRK?

I think so. BRK is a very terse identifier for a file as large as dtrace.h. Though, many of the defines there are quite sloppy about naming.

christos updated this revision to Diff 122786.Jun 3 2023, 5:29 AM

s/BRK/BRK_INSTR/

Harbormaster completed remote builds in B51878: Diff 122786.Jun 3 2023, 5:29 AM
markj accepted this revision.Jun 3 2023, 4:04 PM

Approved

This revision is now accepted and ready to land.Jun 3 2023, 4:04 PM
Closed by commit rGbab7781e78fc: dtrace: deduplicate arm64 breakpoint definition (authored by christos). · Explain WhyJun 3 2023, 5:06 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGbab7781e78fc: dtrace: deduplicate arm64 breakpoint definition.
christos removed a child revision: D40337: kinst: port to arm64.Jun 3 2023, 6:05 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
sys/
6 lines
dev/
fbt/
aarch64/
7 lines

Diff 122680

View Options

sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h

Loading...
View Options

sys/cddl/dev/fbt/aarch64/fbt_isa.c

Loading...