Differential D40356

netlink: use custom uma zone for the mbuf storage
ClosedPublic
Actions

Authored by melifaro on May 31 2023, 6:03 PM.

Tags

None

Referenced Files

	F163529589: D40356.id122688.diff
	Fri, Jul 24, 4:32 AM

	Unknown Object (File)
	Thu, Jul 23, 2:13 AM

	Unknown Object (File)
	Mon, Jul 20, 5:06 AM

	Unknown Object (File)
	Mon, Jul 20, 4:30 AM

	Unknown Object (File)
	Sat, Jul 18, 3:40 PM

	Unknown Object (File)
	Sat, Jul 18, 12:52 PM

	Unknown Object (File)
	Sat, Jul 18, 5:17 AM

	Unknown Object (File)
	Thu, Jun 25, 9:58 PM

Subscribers

zarychtam_plan-b.pwste.edu.pl

Details

Reviewers

glebius
markj
adrian
gallatin

Group Reviewers

Commits

rGd18715475071: netlink: use custom uma zone for the mbuf storage.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51811
Build 48702: arc lint + arc unit

Event Timeline

melifaro created this revision.May 31 2023, 6:03 PM

Herald added subscribers: glebius, imp. · View Herald TranscriptMay 31 2023, 6:03 PM

melifaro requested review of this revision.May 31 2023, 6:03 PM

Harbormaster completed remote builds in B51811: Diff 122670.May 31 2023, 6:03 PM

melifaro added reviewers: network, glebius, markj, adrian, gallatin.May 31 2023, 6:04 PM

melifaro mentioned this in D40348: netlink: retry mbuf allocation in different pool on failure.

I like this approach

This revision is now accepted and ready to land.May 31 2023, 6:25 PM

nice!

Closed by commit rGd18715475071: netlink: use custom uma zone for the mbuf storage. (authored by melifaro). · Explain WhyJun 1 2023, 7:09 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGd18715475071: netlink: use custom uma zone for the mbuf storage..

Neat, thank you for this one! Probably in stable/14 we will have no errors like the one below from stable/13.
[703139] [nl_io] PID 64148 nl_on_transmit: socket RX overflowed, 218 messages (18848 bytes) dropped. bytes: [202095524/805306368] mbufs: [1073741312/1073741824]

melifaro mentioned this in D40368: netlink: use netlink mbufs in the mbuf chains..Jun 1 2023, 8:15 AM

melifaro mentioned this in rGc1839039b193: netlink: use netlink mbufs in the mbuf chains..Jun 2 2023, 1:19 PM

Revision Contents
Changeset List

Path

Size

sys/

netlink/

netlink_message_writer.c

69 lines

netlink_module.c

2 lines

4 lines

Diff 122670

sys/netlink/netlink_message_writer.c

Loading...

sys/netlink/netlink_module.c

Loading...

sys/netlink/netlink_var.h

Loading...