Page MenuHomeFreeBSD
Differential D39956

dtrace: add register bindings for arm64
ClosedPublic
Actions

Authored by christos on May 4 2023, 1:44 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Apr 8, 7:22 PM
Unknown Object (File)
Fri, Mar 28, 10:03 PM
Unknown Object (File)
Feb 26 2025, 3:37 AM
Unknown Object (File)
Feb 16 2025, 11:46 PM
Unknown Object (File)
Jan 10 2025, 4:59 PM
Unknown Object (File)
Jan 10 2025, 4:57 PM
Unknown Object (File)
Dec 25 2024, 5:50 PM
Unknown Object (File)
Dec 19 2024, 11:16 PM
View All 98 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
markj
mhorne
gnn
Group Reviewers
arm64
Commits
rG21a16d55cc15: dtrace: add register bindings for arm64
Summary

Depends on D39955

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.May 4 2023, 1:44 PM
Herald added a reviewer: gnn. · View Herald TranscriptMay 4 2023, 1:44 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
christos requested review of this revision.May 4 2023, 1:44 PM
markj added a reviewer: arm64.May 4 2023, 1:51 PM
mhorne added inline comments.May 4 2023, 2:29 PM
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
281

I suggest renaming rp to the more typical tf.

283–297

tf_x[] has 30 elements, therefore only indices 0 to 29.

christos updated this revision to Diff 121504.May 4 2023, 2:35 PM
christos marked 2 inline comments as done.

Address Mitchell's comments.

christos added inline comments.May 4 2023, 2:37 PM
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
281

I'll submit a different patch that changes rp to tf or frame across all architectures.

mhorne accepted this revision.May 4 2023, 2:41 PM

LGTM

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
281

Sounds great!

This revision is now accepted and ready to land.May 4 2023, 2:41 PM
christos marked an inline comment as done.May 4 2023, 2:47 PM
markj accepted this revision.May 22 2023, 8:03 PM

Approved (with the suggested change applied)

sys/cddl/dev/dtrace/aarch64/regset.h
75

so that this doesn't look like a typo at first glance

Closed by commit rG21a16d55cc15: dtrace: add register bindings for arm64 (authored by christos). · Explain WhyMay 23 2023, 2:20 PM
This revision was automatically updated to reflect the committed changes.
christos marked an inline comment as done.
christos added a commit: rG21a16d55cc15: dtrace: add register bindings for arm64.
christos removed a parent revision: D39955: dtrace: implement dtrace_instr_size() for arm64.May 23 2023, 2:22 PM

Revision Contents
Changeset List

PathSize
cddl/
lib/
libdtrace/
1 line
74 lines
sys/
cddl/
dev/
dtrace/
aarch64/
18 lines
35 lines

Diff 122296

View Options

cddl/lib/libdtrace/Makefile

Show First 20 Lines • Show All 127 Lines • ▼ Show 20 Lines
.if ${MACHINE_CPUARCH} == "riscv" .if ${MACHINE_CPUARCH} == "riscv"
SRCS+= instr_size.c SRCS+= instr_size.c
DSRCS+= regs_riscv.d DSRCS+= regs_riscv.d
.endif .endif
.if ${MACHINE_CPUARCH} == "aarch64" .if ${MACHINE_CPUARCH} == "aarch64"
SRCS+= instr_size.c SRCS+= instr_size.c
DSRCS+= regs_aarch64.d
.endif .endif
YFLAGS+=-d YFLAGS+=-d
LIBADD= ctf elf proc pthread rtld_db LIBADD= ctf elf proc pthread rtld_db
CLEANFILES= dt_errtags.c dt_names.c CLEANFILES= dt_errtags.c dt_names.c
.include <bsd.lib.mk> .include <bsd.lib.mk>
dt_errtags.c: ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/dt_errtags.h dt_errtags.c: ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/dt_errtags.h
sh ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/mkerrtags.sh < ${.ALLSRC} > ${.TARGET} sh ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/mkerrtags.sh < ${.ALLSRC} > ${.TARGET}
dt_names.c: ${OPENSOLARIS_SYS_DISTDIR}/uts/common/sys/dtrace.h dt_names.c: ${OPENSOLARIS_SYS_DISTDIR}/uts/common/sys/dtrace.h
sh ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/mknames.sh < ${.ALLSRC} > ${.TARGET} sh ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/mknames.sh < ${.ALLSRC} > ${.TARGET}
View Options

cddl/lib/libdtrace/regs_aarch64.d

  • This file was added.
/*
* SPDX-License-Identifier: CDDL 1.0
*
* Copyright 2023 Christos Margiolis <christos@FreeBSD.org>
*/
inline int R_X0 = 0;
#pragma D binding "1.13" R_X0
inline int R_X1 = 1;
#pragma D binding "1.13" R_X1
inline int R_X2 = 2;
#pragma D binding "1.13" R_X2
inline int R_X3 = 3;
#pragma D binding "1.13" R_X3
inline int R_X4 = 4;
#pragma D binding "1.13" R_X4
inline int R_X5 = 5;
#pragma D binding "1.13" R_X5
inline int R_X6 = 6;
#pragma D binding "1.13" R_X6
inline int R_X7 = 7;
#pragma D binding "1.13" R_X7
inline int R_X8 = 8;
#pragma D binding "1.13" R_X8
inline int R_X9 = 9;
#pragma D binding "1.13" R_X9
inline int R_X10 = 10;
#pragma D binding "1.13" R_X10
inline int R_X11 = 11;
#pragma D binding "1.13" R_X11
inline int R_X12 = 12;
#pragma D binding "1.13" R_X12
inline int R_X13 = 13;
#pragma D binding "1.13" R_X13
inline int R_X14 = 14;
#pragma D binding "1.13" R_X14
inline int R_X15 = 15;
#pragma D binding "1.13" R_X15
inline int R_X16 = 16;
#pragma D binding "1.13" R_X16
inline int R_X17 = 17;
#pragma D binding "1.13" R_X17
inline int R_X18 = 18;
#pragma D binding "1.13" R_X18
inline int R_X19 = 19;
#pragma D binding "1.13" R_X19
inline int R_X20 = 20;
#pragma D binding "1.13" R_X20
inline int R_X21 = 21;
#pragma D binding "1.13" R_X21
inline int R_X22 = 22;
#pragma D binding "1.13" R_X22
inline int R_X23 = 23;
#pragma D binding "1.13" R_X23
inline int R_X24 = 24;
#pragma D binding "1.13" R_X24
inline int R_X25 = 25;
#pragma D binding "1.13" R_X25
inline int R_X26 = 26;
#pragma D binding "1.13" R_X26
inline int R_X27 = 27;
#pragma D binding "1.13" R_X27
inline int R_X28 = 28;
#pragma D binding "1.13" R_X28
inline int R_X29 = 29;
#pragma D binding "1.13" R_X29
inline int R_FP= 29;
#pragma D binding "1.13" R_FP
inline int R_LR = 30;
#pragma D binding "1.13" R_LR
inline int R_SP = 31;
#pragma D binding "1.13" R_SP
inline int R_PC = 32;
#pragma D binding "1.13" R_PC
View Options

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c

Loading...
View Options

sys/cddl/dev/dtrace/aarch64/regset.h

Loading...