eficom: Free comc_port if we can't find the serial port
ClosedPublic
Actions

Authored by imp on May 22 2023, 10:28 PM.

Tags

None

Referenced Files

	F136919532: D40223.id122398.diff
	Thu, Nov 20, 4:09 PM

	F136919479: D40223.id.diff
	Thu, Nov 20, 4:09 PM

	F136919451: D40223.id122260.diff
	Thu, Nov 20, 4:08 PM

	F136918134: D40223.diff
	Thu, Nov 20, 3:57 PM

	Unknown Object (File)
	Fri, Nov 7, 6:13 AM

	Unknown Object (File)
	Wed, Oct 29, 5:49 AM

	Unknown Object (File)
	Oct 11 2025, 4:58 PM

	Unknown Object (File)
	Oct 11 2025, 11:09 AM

Subscribers

Details

Reviewers

manu
kevans
emaste
tsoome

Commits

rG46927f674466: stand/efi/eficom: Free comc_port if we can't find the serial port

Summary

If we can't find the serial port, free comc_port and return early. The
serial port just isn't there.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51621
Build 48512: arc lint + arc unit

Event Timeline

imp created this revision.May 22 2023, 10:28 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 22 2023, 10:28 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.May 22 2023, 10:28 PM

imp added a parent revision: D40222: stand/efi/eficom: Make aarch64 compat code probe correctly.

Harbormaster completed remote builds in B51621: Diff 122260.May 22 2023, 10:28 PM

imp added reviewers: kevans, emaste, tsoome.May 22 2023, 10:32 PM

gallatin added a subscriber: gallatin.May 23 2023, 1:41 PM

kevans accepted this revision.May 24 2023, 7:44 PM

This revision is now accepted and ready to land.May 24 2023, 7:44 PM

Closed by commit rG46927f674466: stand/efi/eficom: Free comc_port if we can't find the serial port (authored by imp). · Explain WhyMay 25 2023, 4:35 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG46927f674466: stand/efi/eficom: Free comc_port if we can't find the serial port.

Revision Contents
Changeset List

Path

Size

stand/

efi/

libefi/

eficom.c

10 lines

Diff 122260

View Options

stand/efi/eficom: Free comc_port if we can't find the serial portClosedPublicActions